Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [multi-domain] clean up the sync:globals event in the event of errors #20811

Merged
merged 3 commits into from
Mar 29, 2022

Conversation

mjhenkes
Copy link
Member

@mjhenkes mjhenkes commented Mar 28, 2022

  • Closes

User facing changelog

n/a

Additional details

This PR cleans up the 'sync:globals' event listener in the event of errors.

I determined which events needed cleaning up by matching up on and off events on a test by test basis.
I used all the error events in the navigation spec and a successful test in the basic auth spec.

How has the user experience changed?

n/a

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@mjhenkes mjhenkes added the topic: cy.origin Problems or enhancements related to cy.origin command label Mar 28, 2022
@mjhenkes mjhenkes self-assigned this Mar 28, 2022
@mjhenkes mjhenkes requested a review from a team as a code owner March 28, 2022 20:36
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 28, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Mar 28, 2022



Test summary

20583 0 278 4Flakiness 6


Run details

Project cypress
Status Passed
Commit b8fb819
Started Mar 29, 2022 2:31 PM
Ended Mar 29, 2022 2:46 PM
Duration 14:36 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

e2e/multi-domain/commands/multi_domain_viewport.spec.ts Flakiness
1 ... > syncs the viewport across multiple domains
2 ... > syncs the viewport across multiple domains
3 ... > syncs the viewport across multiple domains
4 ... > syncs the viewport across multiple domains
commands/navigation_spec.js Flakiness
1 src/cy/commands/navigation > #visit > window immediately resolves and doesn't reload when visiting the same URL with hashes
This comment includes only the first 5 flaky tests. See all 6 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mjhenkes mjhenkes merged commit 3b4b0ef into feature-multidomain Mar 29, 2022
@mjhenkes mjhenkes deleted the md-clean-up-sync-global-listener branch March 29, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: cy.origin Problems or enhancements related to cy.origin command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants