Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: (multi-domain) updating to support path and hash #20953

Merged
merged 5 commits into from
Apr 7, 2022

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Apr 6, 2022

User facing changelog

n/a

Additional details

  • Updated cy.origin to accept a url that contains a path or hash.

How has the user experience changed?

cy.origin now accepts path and hash urls:

cy.origin('http://www.foobar.com/login', () => undefined)
cy.origin('http://www.foobar.com/#hash', () => undefined)

Error when query param is passed:
Screen Shot 2022-04-06 at 5 21 55 PM

PR Tasks

  • Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@mschile mschile added the topic: cy.origin Problems or enhancements related to cy.origin command label Apr 6, 2022
@mschile mschile requested a review from a team as a code owner April 6, 2022 23:24
@mschile mschile requested review from jennifer-shehane and removed request for a team April 6, 2022 23:24
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 6, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Apr 6, 2022



Test summary

4727 0 63 1Flakiness 0


Run details

Project cypress
Status Passed
Commit 9ad8d28
Started Apr 7, 2022 7:50 PM
Ended Apr 7, 2022 8:06 PM
Duration 16:17 💡
OS Linux Debian - 10.10
Browser Electron 94

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mschile mschile merged commit 782d89f into feature-multidomain Apr 7, 2022
@mschile mschile deleted the cross-origin-url-or-domain branch April 7, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: cy.origin Problems or enhancements related to cy.origin command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants