Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: (multi-domain) add experimentalLoginFlows to the settings page #21030

Merged
merged 3 commits into from
Apr 12, 2022

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Apr 11, 2022

User facing changelog

n/a

Additional details

Added the experimentalLoginFlows flag to the settings page.

How has the user experience changed?

Screen Shot 2022-04-11 at 12 26 55 PM

PR Tasks

  • Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 11, 2022

Thanks for taking the time to open a PR!

@mschile mschile removed request for a team April 11, 2022 20:14
@cypress
Copy link

cypress bot commented Apr 11, 2022



Test summary

4737 0 61 1Flakiness 0


Run details

Project cypress
Status Passed
Commit c36751d
Started Apr 12, 2022 3:03 PM
Ended Apr 12, 2022 3:20 PM
Duration 16:49 💡
OS Linux Debian - 10.10
Browser Electron 94

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@AtofStryker AtofStryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like the name might be in flux again 😅 . Out of scope here, but do we need to update the session test names to reflect the new experimental flag?

@mschile
Copy link
Contributor Author

mschile commented Apr 12, 2022

Out of scope here, but do we need to update the session test names to reflect the new experimental flag?

I don't think so, the experimental flag is going away soon so I think it makes sense to leave the session test names to be named after cy.session.

@mschile mschile merged commit d98d0e1 into feature-multidomain Apr 12, 2022
@mschile mschile deleted the md-experimentalLoginFlows-setting branch April 12, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants