fix: do not show incorrectly support file migration step #22015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
estrada9166
commented
Jun 1, 2022
| import _ from 'lodash' | ||
|
|
||
| export const isDefaultSupportFile = (supportFile: string) => { | ||
| if (_.isNil(supportFile) || !_.isBoolean(supportFile) && supportFile.match(/^cypress\/support($|\/index($|\.(ts|js|coffee)$))/)) { |
There was a problem hiding this comment.
Added the coffee ext here
estrada9166
requested review from
jennifer-shehane
and removed request for
a team
tgriesser
approved these changes
Jun 1, 2022
mjhenkes
approved these changes
Jun 1, 2022
flotwig
suggested changes
Jun 1, 2022
….com:cypress-io/cypress into alejandro/fix/migration-step-for-supportFile
ZachJW34
reviewed
Jun 1, 2022
| import _ from 'lodash' | ||
|
|
||
| export const isDefaultSupportFile = (supportFile: string) => { | ||
| if (_.isNil(supportFile) || !_.isBoolean(supportFile) && supportFile.match(/^cypress\/support($|\/index($|\.(ts|js|coffee)$))/)) { |
There was a problem hiding this comment.
I know this code was lifted, but what happens if the user has ./cypress/support/index.js (prefixed with "./"). This is the default file but the regex wouldn't match
There was a problem hiding this comment.
Maybe we should update the regex for something like (^|\.+\/)cypress\/support($|\/index($|\.(ts|js|coffee)$)) what do you think?
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||
flotwig
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
We were showing the supportFile migration step, based on a default
supportFilewhich was a hardcoded string, making the migration flow, show this step even if the custom supportFile set on the config file includes it partially, like for example "repo/src/platform/testing/e2e/cypress/support/index.js"Additional details
Steps to test
cypress/support/index.How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?