chore: Refactor chainer / Commands.add for readability #22571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
flotwig
approved these changes
Jun 29, 2022
Contributor
flotwig
left a comment
flotwig
left a comment
There was a problem hiding this comment.
Nice! Love to see cleanup in this area. It's a 🐻
ryanthemanuel
approved these changes
Jun 29, 2022
BlueWinds
commented
Jun 29, 2022
| return null | ||
| addSelector (name, fn) { | ||
| // TODO: Add overriding stuff. | ||
| return cy.addSelector(name, fn) |
Contributor
Author
There was a problem hiding this comment.
Ah, whoops, slight code-splatter here, had meant to remove this before committing. I'll clean it up in an upcoming refactor. Not used yet, shouldn't be in yet. Same with selectorFns below.
This was referenced Jul 11, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
No user-facing changes.
Additional details
This PR is the first of hopefully several with some cleanup and refactoring of a very hard to read and central part of our code base: How commands are added, queued, and executed.
There are no functional changes. The code is logically identical - but hopefully easier to read, with less internal state tracking and passing around of variables "to be used at some later point."
Steps to test
All cypress tests execute identically. The CI build passing without test changes should show this well enough, but feel free to manually play with it as well.
How has the user experience changed?
UX is unchanged. DX, reading this code, should be far better.
PR Tasks
cypress-documentation?type definitions?