chore: skip or fix flaky tests #23167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
…ss into fix-or-skip-flaky-tests
rachelruderman
commented
Aug 15, 2022
| cy.contains('Your tests are loading...').should('not.exist') | ||
| cy.contains('Your tests are loading...', { timeout: 10000 }).should('not.exist') |
There was a problem hiding this comment.
Hopeful fix for #23306
rachelruderman
commented
Aug 15, 2022
| @@ -1626,16 +1626,14 @@ describe('network stubbing', function () { | |||
| }).then(function () { | |||
| $.post('/post-only', 'quuz').done((responseText) => { | |||
| expect(responseText).to.contain(body) | |||
|
|
|||
| done() | |||
There was a problem hiding this comment.
Fixes 23145. We didn't need done() here -- passing and failing test cases work as expected here without calling done()
This was referenced Aug 15, 2022
rachelruderman
commented
Aug 15, 2022
| @@ -75,18 +75,17 @@ describe('src/cy/commands/actions/type - #type special chars', () => { | |||
| }) | |||
|
|
|||
| context('parseSpecialCharSequences: false', () => { | |||
| it('types special character sequences literally', (done) => { | |||
There was a problem hiding this comment.
All skips and fixes in this file are under the umbrella issue 23160
This was referenced Aug 15, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
n/a
Additional details
This PR skips or fixes flaky tests in CI, thereby restoring our confidence in CI while we work out the kinks. The issues fixed or skipped are commented in the code.
Steps to test
Be impressed by a good amount of green builds in the CircleCI dashboard for this branch. Unfortunately they are not consistently green because we have memory/performance issues where our CPU gets maxed out and causes timeouts sometimes. See issues #23326, #23321 and #23308 for examples of memory exhaustion in CI
How has the user experience changed?
n/a
PR Tasks
cypress-documentation?type definitions?