chore: skip or fix flaky tests II

circle.yml

@@ -36,6 +36,7 @@ macWorkflowFilters: &darwin-workflow-filters
  or:
  - equal: [ develop, << pipeline.git.branch >> ]
  - equal: [ 'tbiethman/22272-globbing-working-dir', << pipeline.git.branch >> ]
+ - equal: [ 'skip-or-fix-flaky-tests-2', << pipeline.git.branch >> ]
  - matches:
  pattern: "-release$"
  value: << pipeline.git.branch >>
@@ -45,6 +46,7 @@ linuxArm64WorkflowFilters: &linux-arm64-workflow-filters
  or:
  - equal: [ develop, << pipeline.git.branch >> ]
  - equal: [ "lmiller/experimental-single-tab-component-testing", << pipeline.git.branch >> ]
+ - equal: [ 'skip-or-fix-flaky-tests-2', << pipeline.git.branch >> ]
  - matches:
  pattern: "-release$"
  value: << pipeline.git.branch >>
@@ -65,6 +67,7 @@ windowsWorkflowFilters: &windows-workflow-filters
  - equal: [ develop, << pipeline.git.branch >> ]
  - equal: [ linux-arm64, << pipeline.git.branch >> ]
  - equal: [ 'marktnoonan/windows-path-fix', << pipeline.git.branch >> ]
+ - equal: [ 'skip-or-fix-flaky-tests-2', << pipeline.git.branch >> ]
  - matches:
  pattern: "-release$"
  value: << pipeline.git.branch >>

npm/cypress-schematic/src/schematics/ng-generate/e2e/index.spec.ts

@@ -30,7 +30,7 @@ describe('@cypress/schematic:e2e ng-generate', () => {
  appTree = await schematicRunner.runExternalSchematicAsync('@schematics/angular', 'application', appOptions, appTree).toPromise()
  })
 
- it('should create cypress spec file', async () => {
+ it('should create cypress spec file', () => {
  return schematicRunner.runSchematicAsync('e2e', { name: 'foo', project: 'sandbox' }, appTree).toPromise().then((tree) => {
  const files = tree.files
 

npm/vite-dev-server/.percy.yml

@@ -4,4 +4,4 @@ snapshot:
  - 1280
  min-height: 1024
 discovery:
- network-idle-timeout: 1000
+ network-idle-timeout: 750

npm/webpack-dev-server/.percy.yml

@@ -4,4 +4,4 @@ snapshot:
  - 1280
  min-height: 1024
 discovery:
- network-idle-timeout: 1000
+ network-idle-timeout: 750

npm/webpack-dev-server/cypress/e2e/angular.cy.ts

@@ -55,7 +55,8 @@ for (const project of WEBPACK_REACT) {
  cy.get('.passed > .num').should('contain', 1)
  })
 
- it('should detect new spec', () => {
+ // TODO: fix flaky test https://github.com/cypress-io/cypress/issues/23455
+ it.skip('should detect new spec', () => {
  cy.visitApp()
 
  cy.withCtx(async (ctx) => {

npm/webpack-dev-server/cypress/e2e/next.cy.ts

@@ -55,7 +55,8 @@ for (const project of WEBPACK_REACT) {
  cy.get('.passed > .num').should('contain', 1)
  })
 
- it('should detect new spec', () => {
+ // TODO: fix flaky test https://github.com/cypress-io/cypress/issues/23417
+ it.skip('should detect new spec', () => {
  cy.visitApp()
 
  cy.withCtx(async (ctx) => {
@@ -73,7 +74,8 @@ for (const project of WEBPACK_REACT) {
  cy.get('.passed > .num').should('contain', 1)
  })
 
- it('should allow import of global styles in support file', () => {
+ // TODO: fix flaky test https://github.com/cypress-io/cypress/issues/23417
+ it.skip('should allow import of global styles in support file', () => {
  cy.visitApp()
  cy.contains('styles.cy.js').click()
  cy.waitForSpecToFinish()

npm/webpack-dev-server/cypress/e2e/nuxt.cy.ts

@@ -49,7 +49,8 @@ for (const project of PROJECTS) {
  cy.get('.passed > .num').should('contain', 1)
  })
 
- it('should detect new spec', () => {
+ // TODO: fix flaky test https://github.com/cypress-io/cypress/issues/23455
+ it.skip('should detect new spec', () => {
  cy.visitApp()
 
  cy.withCtx(async (ctx) => {

packages/app/cypress/e2e/cypress-in-cypress-e2e.cy.ts

@@ -110,7 +110,7 @@ describe('Cypress In Cypress E2E', { viewportWidth: 1500, defaultCommandTimeout:
  .its('href')
  .should('eq', 'http://localhost:4455/__/#/specs')
 
- cy.percySnapshot()
+ // cy.percySnapshot() // TODO: restore when Percy CSS is fixed. See https://github.com/cypress-io/cypress/issues/23435
 
  // should clear after reload
  cy.reload()
@@ -172,7 +172,7 @@ describe('Cypress In Cypress E2E', { viewportWidth: 1500, defaultCommandTimeout:
  // We could consider removing this after percy is
  // up and running for e2e tests.
 
- cy.percySnapshot()
+ // cy.percySnapshot() // TODO: restore when Percy CSS is fixed. See https://github.com/cypress-io/cypress/issues/23435
  })
 
  it('should show visit failure blank page', () => {
@@ -181,7 +181,7 @@ describe('Cypress In Cypress E2E', { viewportWidth: 1500, defaultCommandTimeout:
  .click()
 
  cy.get('[data-model-state="failed"]').should('contain', 'renders the blank page')
- cy.percySnapshot()
+ // cy.percySnapshot() // TODO: restore when Percy CSS is fixed. See https://github.com/cypress-io/cypress/issues/23435
  })
 
  it('set the correct viewport values from CLI', () => {

packages/app/cypress/e2e/cypress-in-cypress-run-mode.cy.ts

@@ -30,7 +30,7 @@ describe('Cypress In Cypress - run mode', { viewportWidth: 1200 }, () => {
  cy.contains('Chrome 1').click()
  cy.contains('Firefox').should('not.exist')
 
- cy.percySnapshot()
+ // cy.percySnapshot() // TODO: restore when Percy CSS is fixed. See https://github.com/cypress-io/cypress/issues/23435
  })
 
  // TODO: fix flaky test https://github.com/cypress-io/cypress/issues/23306
@@ -61,7 +61,7 @@ describe('Cypress In Cypress - run mode', { viewportWidth: 1200 }, () => {
  cy.contains('Chrome 1').click()
  cy.contains('Firefox').should('not.exist')
 
- cy.percySnapshot()
+ // cy.percySnapshot() // TODO: restore when Percy CSS is fixed. See https://github.com/cypress-io/cypress/issues/23435
  })
 
  it('hides reporter when NO_COMMAND_LOG is set in run mode', () => {

packages/app/cypress/e2e/cypress-in-cypress.cy.ts

@@ -41,7 +41,7 @@ describe('Cypress in Cypress', { viewportWidth: 1500, defaultCommandTimeout: 100
  expect(ctx.actions.project.launchProject).to.have.been.called
  })
 
- cy.percySnapshot()
+ // cy.percySnapshot() // TODO: restore when Percy CSS is fixed. See https://github.com/cypress-io/cypress/issues/23435
  })
 
  it(`handles automation missing in ${testingType}`, () => {
@@ -74,11 +74,11 @@ describe('Cypress in Cypress', { viewportWidth: 1500, defaultCommandTimeout: 100
 
  cy.contains('h3', 'The Cypress extension is missing')
 
- cy.percySnapshot()
+ // cy.percySnapshot() // TODO: restore when Percy CSS is fixed. See https://github.com/cypress-io/cypress/issues/23435
 
  cy.get('[data-cy="select-browser"]').click()
 
- cy.percySnapshot()
+ // cy.percySnapshot() // TODO: restore when Percy CSS is fixed. See https://github.com/cypress-io/cypress/issues/23435
 
  cy.withCtx((ctx, { sinon }) => {
  sinon.stub(ctx.actions.project, 'launchProject').resolves()
@@ -92,7 +92,8 @@ describe('Cypress in Cypress', { viewportWidth: 1500, defaultCommandTimeout: 100
  })
  })
 
- it(`scales the AUT correctly in ${testingType}`, () => {
+ // TODO: fix flaky test https://github.com/cypress-io/cypress/issues/23307
+ it.skip(`scales the AUT correctly in ${testingType}`, () => {
  const assertNoScaleShown = () => {
  // check that no message about scale % is shown,
  // meaning the AUT is at 100% scale
@@ -117,7 +118,7 @@ describe('Cypress in Cypress', { viewportWidth: 1500, defaultCommandTimeout: 100
 
  // validate that the width we set in `withCtx` above is the starting point
  cy.get(`[data-cy="reporter-panel"]`).invoke('outerWidth').should('eq', 800)
- cy.percySnapshot('initial state')
+ // cy.percySnapshot('initial state') // TODO: restore when Percy CSS is fixed. See https://github.com/cypress-io/cypress/issues/23435
 
  cy.contains('[aria-controls=reporter-inline-specs-list]', 'Specs')
  .click({ force: true })
@@ -152,7 +153,10 @@ describe('Cypress in Cypress', { viewportWidth: 1500, defaultCommandTimeout: 100
  assertNoScaleShown()
  }
 
- cy.percySnapshot(`panel 2 at ${ position } px`)
+ /*
+ TODO: restore when Percy CSS is fixed. See https://github.com/cypress-io/cypress/issues/23435
+ cy.percySnapshot(`panel 2 at ${ position } px`)
+ */
  })
  })
 
@@ -171,11 +175,11 @@ describe('Cypress in Cypress', { viewportWidth: 1500, defaultCommandTimeout: 100
  cy.contains('Expand Specs List')
 
  assertNoScaleShown()
- cy.percySnapshot('tall viewport')
+ // cy.percySnapshot('tall viewport') // TODO: restore when Percy CSS is fixed. See https://github.com/cypress-io/cypress/issues/23435
 
  cy.viewport(1500, 400)
  cy.contains(testingTypeExpectedScales[`${ testingType }ShortViewport`]).should('be.visible')
- cy.percySnapshot('short viewport')
+ // cy.percySnapshot('short viewport') // TODO: restore when Percy CSS is fixed. See https://github.com/cypress-io/cypress/issues/23435
  })
 
  cy.get('[data-cy="select-browser"]').as('selectBrowser')

packages/app/cypress/e2e/runner/sessions.ui.cy.ts

@@ -56,7 +56,7 @@ describe('runner/cypress sessions.ui.spec', {
  validateSetupSessionGroup()
  })
 
- cy.percySnapshot()
+ // cy.percySnapshot() // TODO: restore when Percy CSS is fixed. See https://github.com/cypress-io/cypress/issues/23435
 
  cy.get('.command-name-session').eq(0).get('.command-expander').first().click()
  cy.get('.command').should('have.length', 2)
@@ -91,7 +91,7 @@ describe('runner/cypress sessions.ui.spec', {
  .contains('runValidation')
  })
 
- cy.percySnapshot()
+ // cy.percySnapshot() // TODO: restore when Percy CSS is fixed. See https://github.com/cypress-io/cypress/issues/23435
 
  cy.get('.command-name-session').eq(0).get('.command-expander').first().click()
 
@@ -128,7 +128,7 @@ describe('runner/cypress sessions.ui.spec', {
 
  cy.contains('CypressError')
 
- cy.percySnapshot()
+ // cy.percySnapshot() // TODO: restore when Percy CSS is fixed. See https://github.com/cypress-io/cypress/issues/23435
  })
 
  describe('restores saved session', () => {
@@ -246,7 +246,8 @@ describe('runner/cypress sessions.ui.spec', {
  .find('.command-alias')
  .contains('runValidation')
  })
- .percySnapshot()
+
+ // cy.percySnapshot() // TODO: restore when Percy CSS is fixed. See https://github.com/cypress-io/cypress/issues/23435
 
  cy.get('.runnable-err').should('have.length', 1)
 
@@ -309,7 +310,7 @@ describe('runner/cypress sessions.ui.spec', {
  .find('.command-alias')
  .contains('runValidation')
  })
- .percySnapshot()
+ // cy.percySnapshot() // TODO: restore when Percy CSS is fixed. See https://github.com/cypress-io/cypress/issues/23435
 
  cy.get('.runnable-err').should('have.length', 2)
  })
@@ -323,7 +324,7 @@ describe('runner/cypress sessions.ui.spec', {
  })
 
  validateSessionsInstrumentPanel(['user1', 'user2'])
- cy.percySnapshot()
+ // cy.percySnapshot() // TODO: restore when Percy CSS is fixed. See https://github.com/cypress-io/cypress/issues/23435
  })
 })
 

packages/app/cypress/e2e/runner/support/snapshot-reporter.ts

@@ -1,4 +1,4 @@
-// Takes percy snapshot with navigation/AUT hidden and run duration mocked
+// Takes percy snapshot with navigation/AUT/reporter hidden
 export const snapshotReporter = () => {
  cy.percySnapshot({
  width: 450,

packages/app/cypress/e2e/runs.cy.ts

@@ -658,7 +658,7 @@ describe('App: Runs', { viewportWidth: 1200 }, () => {
  moveToRunsPage()
 
  cy.contains('h2', 'Cannot connect to the Cypress Dashboard')
- cy.percySnapshot()
+ // cy.percySnapshot() // TODO: restore when Percy CSS is fixed. See https://github.com/cypress-io/cypress/issues/23435
 
  cy.remoteGraphQLIntercept((obj) => {
  if (obj.operationName === 'Runs_currentProject_cloudProject_cloudProjectBySlug') {

packages/app/cypress/e2e/settings.cy.ts

@@ -438,7 +438,7 @@ describe('App: Settings without cloud', () => {
  cy.contains(`channel: 'stable',`)
  cy.contains(`displayName: 'Chrome',`)
 
-  cy.percySnapshot()
+ // cy.percySnapshot() // TODO: restore when Percy CSS is fixed. See https://github.com/cypress-io/cypress/issues/23435
  })
  })
 })

packages/app/cypress/e2e/sidebar_navigation.cy.ts

@@ -77,7 +77,7 @@ describe('Sidebar Navigation', { viewportWidth: 1280 }, () => {
 
  it('expands the left nav bar by default', () => {
  cy.findByTestId('sidebar').should('have.css', 'width', '248px') // assert width to ensure transition has finished
- cy.percySnapshot()
+ // cy.percySnapshot() // TODO: restore when Percy CSS is fixed. See https://github.com/cypress-io/cypress/issues/23435
  })
 
  it('highlights indicator on hover showing you can click to expand', () => {
@@ -87,14 +87,15 @@ describe('Sidebar Navigation', { viewportWidth: 1280 }, () => {
  cy.findByTestId('toggle-sidebar').realHover()
  cy.get(navIndicatorSelector).should('be.visible')
 
- cy.percySnapshot()
+ // cy.percySnapshot() // TODO: restore when Percy CSS is fixed. See https://github.com/cypress-io/cypress/issues/23435
  })
 
  it('closes the left nav bar when clicking the expand button (if expanded)', () => {
  cy.findByTestId('sidebar').contains('todos').should('be.visible')
  cy.findByTestId('toggle-sidebar').click()
  cy.findByTestId('sidebar').contains('todos').should('not.be.visible')
- cy.percySnapshot()
+
+ // cy.percySnapshot() // TODO: restore when Percy CSS is fixed. See https://github.com/cypress-io/cypress/issues/23435
  })
 
  it('closes the left nav bar when clicking the expand button and persist the state if browser is refreshed', () => {
@@ -107,7 +108,7 @@ describe('Sidebar Navigation', { viewportWidth: 1280 }, () => {
 
  cy.findByTestId('sidebar').contains('todos').should('not.be.visible')
 
- cy.percySnapshot()
+ // cy.percySnapshot() // TODO: restore when Percy CSS is fixed. See https://github.com/cypress-io/cypress/issues/23435
  })
 
  it('has menu item that shows the keyboard shortcuts modal (unexpanded state)', () => {
@@ -123,7 +124,7 @@ describe('Sidebar Navigation', { viewportWidth: 1280 }, () => {
  cy.get('li span').contains('s')
  cy.get('li span').contains('f')
 
- cy.percySnapshot()
+ // cy.percySnapshot() // TODO: restore when Percy CSS is fixed. See https://github.com/cypress-io/cypress/issues/23435
  cy.get('[aria-label="Close"]').click()
  cy.findAllByTestId('keyboard-modal').should('not.exist')
  })
@@ -134,7 +135,7 @@ describe('Sidebar Navigation', { viewportWidth: 1280 }, () => {
 
  cy.findByTestId('sidebar-header').trigger('mouseenter')
  cy.contains('.v-popper--some-open--tooltip', 'todos')
- cy.percySnapshot()
+ // cy.percySnapshot() // TODO: restore when Percy CSS is fixed. See https://github.com/cypress-io/cypress/issues/23435
  cy.findByTestId('sidebar-header').trigger('mouseout')
 
  cy.findByTestId('sidebar-link-runs-page').trigger('mouseenter')
@@ -243,7 +244,7 @@ describe('Sidebar Navigation', { viewportWidth: 1280 }, () => {
  cy.findAllByTestId('spec-item').first().click()
  cy.location('hash').should('contain', '#/specs/runner')
  cy.contains('.router-link-exact-active', 'Specs').should('not.exist')
- cy.percySnapshot()
+ // cy.percySnapshot() // TODO: restore when Percy CSS is fixed. See https://github.com/cypress-io/cypress/issues/23435
 
  cy.findByTestId('sidebar-link-specs-page').click()
  cy.location('hash').should('equal', '#/specs')