Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app crashing on websocket upgrade request over https #23449

Merged
merged 8 commits into from
Aug 19, 2022

Conversation

ryanthemanuel
Copy link
Collaborator

User facing changelog

App no longer crashes on websocket upgrade request over https

Additional details

A change was made on on #20107 to support fetch requests in the proxy. For that change, we needed to set options.uri in our HttpsAgent.addRequest method. It was assumed that this would cover the existing logic to set options.uri as well, however, this didn't cover the case where we have a client certificate over https. This PR restores that functionality.

Steps to test

You can test this by uncommenting the code change and running the new test and see that there is a failure. You can also use the test project provided by @AtofStryker here

How has the user experience changed?

The app no longer crashes when there is

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 19, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Aug 19, 2022



Test summary

41474 0 1434 0Flakiness 15


Run details

Project cypress
Status Passed
Commit 34b52d5
Started Aug 19, 2022 7:37 PM
Ended Aug 19, 2022 7:52 PM
Duration 15:03 💡
OS Linux Debian - 11.3
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/commands/net_stubbing.cy.ts Flakiness
1 network stubbing > intercepting request > can add a body to a request that does not have one
2 network stubbing > intercepting request > can delay with deprecated delayMs param
3 network stubbing > intercepting request > can delay with deprecated delayMs param
4 network stubbing > intercepting request > can delay with deprecated delayMs param
5 ... > with `times` > only uses each handler N times
This comment includes only the first 5 flaky tests. See all 15 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@rachelruderman rachelruderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress crashes on websocket upgrade request over https after update from 9.7.0 to 10.0.3
3 participants