collect GitLab pipeline id and url for #2343 #2345
Merged
+91
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahmutov
commented
Aug 15, 2018
| @@ -219,6 +219,18 @@ updateInstance = (options = {}) -> | |||
| else | |||
| null | |||
|
|
|||
| getCommitFromGitOrCi = (git) -> | |||
| la(check.object(git), 'expected git information object', git) | |||
| ciProvider.commitDefaults({ | |||
There was a problem hiding this comment.
fills any properties that have null value
bahmutov
commented
Aug 15, 2018
| @@ -81,7 +81,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@cypress/browserify-preprocessor": "1.1.0", | |||
| "@cypress/commit-info": "^1.2.2", | |||
| "@cypress/commit-info": "2.0.0", | |||
There was a problem hiding this comment.
v2 returns null for values it could not determine, breaking gift compatibility, but making it simple to fill values using CI environment variables
This was referenced Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI_COMMIT_REF_NAMEis there in the environment variables on GitLab, why isn't it in the dashboard (fixed GitLab detection predicate function)