Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(server): remove dead runner code #23542

Merged
merged 1 commit into from
Aug 29, 2022
Merged

chore(server): remove dead runner code #23542

merged 1 commit into from
Aug 29, 2022

Conversation

emilyrohrbough
Copy link
Member

chore: remove dead code -- lives in data-context/src/sources/HtmlDataSource.ts

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 24, 2022

Thanks for taking the time to open a PR!

Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to delete dead code - definitely need to

  1. get server properly type safe
  2. figure out what exactly goes in data-context and server, and how the seam between the two should be decided


export const runner = {
serve (req, res, runnerPkg: RunnerPkg, options: ServeOptions) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not realize this was unused... I wonder if this should live in data-context? Server seems like a better place for, well, serving things. The line between server/data-context is really blurred, though. I think the goal was incrementally moving things so we could strongly type them, but a lot of things ended up just getting dumped there (probably since it has more strict types, so it's easier to work in).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah the line between the data-context & server is very blurred. I think intention was to separate server vs config/setup type concepts but we didn't get all the way there how intertwined some of this is

@lmiller1990
Copy link
Contributor

lmiller1990 commented Aug 29, 2022

Going to go ahead and merge this up -- it's dead code, all CI is passing, I don't see much risk and there's not any additional manual testing required.

As an aside, we definitely need a process for getting more :eyes on these easy to review but high value, spontaneous PRs.

@lmiller1990 lmiller1990 merged commit b08bc27 into develop Aug 29, 2022
@lmiller1990 lmiller1990 deleted the rm-dead-code branch August 29, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants