feat: adding svelte component testing support #23553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jessica Sachs <jess@jessicasachs.io>
…-support feat: Add svelte detection to wizard
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
ZachJW34
changed the title
|
I fixed up the types in e53f3a1 Before: After: |
lmiller1990
approved these changes
Aug 26, 2022
mike-plummer
approved these changes
Aug 26, 2022
npm/svelte/README.md
Outdated
| ## Install | ||
|
|
||
| - Requires Svelte >= 3 | ||
| - Requires Cypress v10.6.0 or later |
There was a problem hiding this comment.
version number incorrect
system-tests/project-fixtures/svelte/cypress/support/component.js
Outdated
Show resolved
Hide resolved
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Svelte Component Testing Support
Additional details
Merging of the Svelte Feature branch into develop, no additional changes from the two previously merged and approved PRS: #23519 and #23441
Documentation is WIP: cypress-io/cypress-documentation#4677
Steps to test
You can scaffold a new svelte project with
npm init viteand choose Svelte (the scaffold has outdated peer deps so update@sveltejs/vite-plugin-svelteandviteto latest). Then you can pointyarn cypress:openat the svelte project and get to testing!There are also some system tests in
system-tests/test/component_testing_spec.tsthat test both webpack and vite.How has the user experience changed?
Screen.Recording.2022-08-25.at.2.06.27.PM.mov
PR Tasks
cypress-documentation?type definitions?