Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(percy): add percy context to finalize job #23558

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Aug 25, 2022

  • Closes

User facing changelog

Additional details

Steps to test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 25, 2022

Thanks for taking the time to open a PR!

@flotwig flotwig marked this pull request as ready for review August 25, 2022 23:01
@chrisbreiding chrisbreiding self-requested a review August 25, 2022 23:03
@cypress
Copy link

cypress bot commented Aug 25, 2022



Test summary

39609 0 3371 0Flakiness 0


Run details

Project cypress
Status Passed
Commit ba957ce
Started Aug 25, 2022 10:59 PM
Ended Aug 25, 2022 11:13 PM
Duration 14:11 💡
OS Linux Debian - 11.3
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig
Copy link
Contributor Author

flotwig commented Aug 25, 2022

I think percy-finalize is only failing because develop is missing a finalized Percy build... going to merge 🤞

@flotwig flotwig merged commit e80e778 into develop Aug 25, 2022
@flotwig flotwig deleted the percy-context-finalize branch August 25, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants