chore(webkit): add before:browser:launch and download support #23662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
~60 tests skipped out of ~99: * ~6 skipped due to needing multidomain support * ~8 skipped due to missing before:browser:launch support * ~22 skipped due to broken stack traces
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
flotwig
commented
Sep 2, 2022
lmiller1990
reviewed
Sep 6, 2022
| * However, the Electron binary does not support an entrypoint, leading Cypress to think it's being opened in global mode (no args) when this fn is called. | ||
| * Solution is to filter out the problematic function. | ||
| * TODO(webkit): do we want to run this cleanup script another way? | ||
| * @see https://github.com/microsoft/playwright/blob/7e2aec7454f596af452b51a2866e86370291ac8b/packages/playwright-core/src/utils/processLauncher.ts#L191-L203 |
There was a problem hiding this comment.
Ahh this must have been tricky to debug. Nice.
There was a problem hiding this comment.
Super tricky. The stdout/stderr isn't inherited and it doesn't pass --inspect-brk so it was like a ghost process. I eventually figured out what was going on by adding logging using fs.createWriteStream and tail'ing the file.
|
I tried video recording. It worked! I first tested a basic site using a JS based download. It works great (including video). describe('empty spec', () => {
it('passes', () => {
cy.visit('http://localhost:8080')
cy.get('input#btn').click()
cy.readFile(`${Cypress.config('downloadsFolder')}/output.txt`)
})
})Website: <!DOCTYPE html>
<html>
<head>
<title>
How to Download files Using JavaScript
</title>
</head>
<body>
<textarea id="text">DelftStack</textarea>
<br />
<input type="button" id="btn" value="Download" />
<script>
function download(filename, textInput) {
var element = document.createElement('a');
element.setAttribute('href','data:text/plain;charset=utf-8, ' + encodeURIComponent(textInput));
element.setAttribute('download', filename);
document.body.appendChild(element);
element.click();
//document.body.removeChild(element);
}
document.getElementById("btn")
.addEventListener("click", function () {
var text = document.getElementById("text").value;
var filename = "output.txt";
download(filename, text);
}, false);
</script>
</body>
</html>I also tried using a spammy test download site for my testing - it's more "real world". Edit: this website exhibits the same weird problems in Cypress + Chrome - I think the problems are not WK specific. describe('empty spec', () => {
it('passes', () => {
cy.visit('https://file-examples.com/index.php/sample-documents-download/sample-rtf-download/')
cy.get('a').contains('Download sample rtf file').click()
})
})It did work in open mode - kind of - the file was downloaded. Due to the websites's jankiness, it somehow injected a Google Ad into the command log (wtf?). Also it shows an error:
It failed in run mode: |
lmiller1990
approved these changes
Sep 6, 2022
2 tasks
tbiethman
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
n/a
Additional details
before:browser:launchsupport.launchOptions.extensionsisn't supported since WK doesn't take extensions.config.downloadsFolderand download events.cypress runended, since it was making local system-tests fail.Steps to test
Refer to #23579 testing steps for instructions on installing WebKit.
before:browser:launchusing WebKit, observe that the event is hit and that the launchOptions can be edited.downloadsFolderwhen using WebKit.openmode.How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?