-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove rawJson from Cypress.state() #23948
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Since this is not part of the public API (undocumented) I don't know if we need to mark it as BREAKING, do we? BREAKING is usually for public API changes (I understand this might technically break someone, though, but it's equally weird to see a deprecation in a major that was never an official feature to begin with). |
yeah, I can go either way, but would rather we just push it out in 11.0 just in case. |
rawJson
from stored Cypress state #23945develop/packages/driver/src/cypress.ts#L222
Check the config value received when Cypress starts and you'll see we are storing the rawJson with the value & resolved.from values in Cypress.state().
We collect this date for presenting the config resolution in the App, but the driver doesn't need/use this info.
cypress-documentation
?type definitions
?