Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove rawJson from Cypress.state() #23948

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Conversation

emilyrohrbough
Copy link
Member

@emilyrohrbough emilyrohrbough commented Sep 22, 2022

develop/packages/driver/src/cypress.ts#L222

Check the config value received when Cypress starts and you'll see we are storing the rawJson with the value & resolved.from values in Cypress.state().

We collect this date for presenting the config resolution in the App, but the driver doesn't need/use this info.

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 22, 2022

Thanks for taking the time to open a PR!

@emilyrohrbough emilyrohrbough changed the title breaking: remove rawJson from Cypress.state() chore(breaking): remove rawJson from Cypress.state() Sep 22, 2022
@cypress
Copy link

cypress bot commented Sep 22, 2022



Test summary

40224 0 3354 0Flakiness 1


Run details

Project cypress
Status Passed
Commit 6d3e2ad
Started Oct 12, 2022 2:13 PM
Ended Oct 12, 2022 2:29 PM
Duration 15:33 💡
OS Linux Debian - 11.3
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/e2e/origin/config_env.cy.ts Flakiness
1 cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lmiller1990
Copy link
Contributor

Since this is not part of the public API (undocumented) I don't know if we need to mark it as BREAKING, do we? BREAKING is usually for public API changes (I understand this might technically break someone, though, but it's equally weird to see a deprecation in a major that was never an official feature to begin with).

@emilyrohrbough emilyrohrbough changed the title chore(breaking): remove rawJson from Cypress.state() chore: remove rawJson from Cypress.state() Oct 11, 2022
@emilyrohrbough
Copy link
Member Author

yeah, I can go either way, but would rather we just push it out in 11.0 just in case.

@emilyrohrbough emilyrohrbough merged commit c2397e9 into 11.0.0 Oct 12, 2022
@emilyrohrbough emilyrohrbough deleted the remove-raw-json branch October 12, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants