fix: add default export detection #24954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
Base automatically changed from
astone123/create-from-react-server
to
feature/create-from-react-component
December 5, 2022 15:25
ZachJW34
force-pushed
the
zachw/cfr-default-exports
branch
from
50d2101
to
e3756fa
Compare
|
Test summaryRun details
View run in Cypress Dashboard ➡️ FlakinessThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
I think this is fine to skip for the initial release, talked to @astone123 but we should just ignore non capital exports - so HOCs are off the table, at least for now. |
lmiller1990
reviewed
Dec 6, 2022
lmiller1990
approved these changes
Dec 6, 2022
ZachJW34
commented
Dec 6, 2022
lmiller1990
approved these changes
Dec 6, 2022
lmiller1990
added a commit
that referenced
this pull request
Dec 19, 2022
* feat: server logic for create from React component (#24881) Co-authored-by: Ryan Manuel <ryanm@cypress.io> Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com> * fix: add default export detection (#24954) Co-authored-by: astone123 <adams@cypress.io> * update cache * update yarn.lock to fix builds * fix: compilation with webpack preprocessor * feat: create from React component UI (#24982) * feat: WIP server logic for create from React component * feat: add more tests; error handling * feat: WIP create from React UI * feat: PR feedback [run CI] * feat: try committing snapshot cache changes [run ci] * feat: try re-generating snapshot [run ci] * fix build * regenerate cache on darwin * update caches * Revert "feat: try re-generating snapshot [run ci]" This reverts commit d763e1f. * fix typing error * types * fix test * chore: try using react-docgen@6.0.0-alpha.3 * update test * regen linux snapshot * update snapshots for darwin * re-gen linux snapshot * yarn install * update snapshots * update snapshot metadata * update snapshots due to babel deps changing slightly * make react docgen a dep * update tests * revert * snapshots again?? * revert * update * update * try change snapshot * change snap * update snap * feat: remove unnecessary ts-ignore * feat: add more test cases * feat: create CodegenActions; other minor refactors * feat: continue UI work * feat: ignore config and Cypress-related files * feat: PR feedback * update Vue component link * merge in default export work * consolidate graphql queries * other misc feedback * use network-only policy to fetch files; include cypress/ dir for code gen candidates; fix type error * add basic e2e test * fix app integration tests * refactor and fix app component and webpack dev server tests * add error state; fix unit tests [skip ci] * simplify generator show logic [skip ci] * more testing * fix types * style updates [skip ci] * fix error state [skip ci] * fix list padding [skip ci] * use slots (#25079) * add more tests; fix unit tests * fix types * fix test describe * add percy snapshots for new list * update trouble rendering banner link [skip ci] * use collapsible component * use button for component list items * fix tests * build binaries * revert changes to circle config * remove eslintignore and extra loading div [skip ci] because we know it will fail * revert changes to framework glob patterns [skip ci] Co-authored-by: Ryan Manuel <ryanm@cypress.io> Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com> * feat: pass parser options to allow parsing of tsx files (#25145) * fix create from component e2e test * build binaries [run ci] * fix component tests [run ci] * regen windows snapshot Co-authored-by: Ryan Manuel <ryanm@cypress.io> Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com> Co-authored-by: Zachary Williams <ZachJW34@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
na
Additional details
Allows the detection of default exports, as well as exports that have been aliased e.g.
export { Foo as bar }. There are some edge-cases that aren't covered like HOCs (export default connect(Counter)) but adding support for those would be complex.Steps to test
Run the system-tests for data-context
yarn workspace @packages/data-context testPR Tasks
cypress-documentation?type definitions?