-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to Vite 4 and Rollup 3 #25101
Conversation
Thanks for taking the time to open a PR!
|
@@ -11,14 +11,14 @@ declare namespace Cypress { | |||
} | |||
|
|||
type ReferenceAlias = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why these changed - all I did was run yarn
. The changes are more in line with the style of the rest of the file, though, so I think it's okay.
Looks good, though I'd like to check the binary before we merge, could you run those jobs for this branch? I'd want to check live reloading in open mode to make sure dependency changes didn't introduce any issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@marktnoonan this is just for our internal dependencies, we use the user's Vite version - we don't ship Vite or Rollup in production, neither of these dependencies is present in the binary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but just to cross the t's and dot the i's there have been a couple point releases in the last day:
vite@4.0.1
rollup@3.7.3
Worth bumping?
@marktnoonan neither rollup or vite is in the binary, no need - can verify by doing @mike-plummer we can, I'm not sure why renovate isn't doing this for us 🤔 Doing that now. |
* chore: try move to rollup 3 and vite 4 * bump to latest versions
Vite 4 migration: https://vitejs.dev/guide/migration.html
Rollup 3 migration: https://rollupjs.org/guide/en/#migration
None of the breaking changes seems to impact us. We only use a very simple Rollup configuration to bundle things in
npm/*
, and we don't do anything too strange with Vite, either. Great!