chore: remove lint-changed from scripts/docs #25308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
flotwig
force-pushed
the
rm-lint-changed
branch
from
d1eae36
to
d02a164
Compare
| @@ -42,7 +42,6 @@ | |||
| "get-next-version": "node scripts/get-next-version.js", | |||
| "postinstall": "node ./scripts/run-postInstall.js", | |||
| "lint": "lerna run lint --no-bail --concurrency 2", | |||
| "lint-changed": "lint-changed", | |||
There was a problem hiding this comment.
Did you log an issue to fix the broken script? Or remove in a MVB? Find with removing but if it's not working and its from something we ship, seems like this will get lost.
There was a problem hiding this comment.
I assumed that because the tests in eslint-plugin-dev pass, that the scripts aren't totally broken, but on second glance I actually cannot successfully invoke them no matter what I try. It looks like @cypress-io/tools is looking at removing eslint-plugin-dev entirely, so I commented to ask if we can blast these scripts into orbit as part of that change: #24251 (comment)
emilyrohrbough
approved these changes
Dec 29, 2022
ZachJW34
approved these changes
Jan 4, 2023
tgriesser
added a commit
that referenced
this pull request
Jan 18, 2023
* develop: (45 commits) fix: re-enable CYPRESS_INTERNAL_VITE_DEV development (#25364) fix: add skip domain injection description (#25463) fix: revert CSP header and script-src addition (#25445) chore: Update v8 snapshot cache (#25401) feat: Do not strip CSP headers from HTTPResponse (#24760) fix: keep spaces in formatted output in test runner (#24687) fix: Restrict dependency versions to known supported ranges (#25380) chore: Update v8 snapshot cache (#25370) feat: experimental skip domain injection (#25307) chore: support vite v4 for component testing (#25365) feat: Use JSX/TSX in generated spec filenames (#25318) docs(angular): Properties that are spied upon have to be defined within `componentProperties` instead of on root level. (#25359) chore: remove lint-changed from scripts/docs (#25308) chore: bump to 12.3.0 [skip ci] (#25355) fix: make NODE_ENV "production" for prod builds of launchpad (#25320) fix: .contains() should only return one element at all times (#25250) feat: add currentRetry to Cypress API (#25297) chore: release @cypress/webpack-dev-server-v3.2.2 chore: release create-cypress-tests-v2.0.1 fix: change wording for spec creation (#25271) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
n/a
Additional details
lint-stagedalready runseslint --fix, so there's not a situation where a functionallint-changedwould be needed anyways.I kept the source code innpm/eslint-plugin-devbecause tests for it do pass and it's possible it's being used outside of the monorepo.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?