Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 12.5.0 release #25648

Merged
merged 2 commits into from
Jan 31, 2023
Merged

chore: 12.5.0 release #25648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e9eea5
12.5.0 release - bump version and correct changelog
emilyrohrbough Jan 31, 2023
3eb283b
update entry to include discussion and blog post links
emilyrohrbough Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions cli/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,23 @@
<!-- See the ../guides/writing-the-cypress-changelog.md for details on writing the changelog. -->
## 12.5.0

_Released 01/31/2023 (PENDING)_
_Released 01/31/2023_

**Features:**

- Easily debug failed CI test runs right from your local Cypress app with the new Debug page, powered by Cypress Cloud. For more details, see the [Debug documentation](https://on.cypress.io/debug-page). Addressed in [#25488](https://github.com/cypress-io/cypress/pull/25488).
- Easily debug failed CI test runs recorded to the Cypress Cloud from your local Cypress app with the new Debug page. Please leave any feedback [here](https://github.com/cypress-io/cypress/discussions/25649). Your feedback will help us make decisions to improve the Debug experience. For more details, see [our blog post](https://on.cypress.io/debug-page-release). Addressed in [#25488](https://github.com/cypress-io/cypress/pull/25488).

**Bugfixes:**
**Performance:**

- Fixed an issue where alternative Microsoft Edge Beta, Canary, and Dev binary versions were not being discovered by Cypress.
Fixes [#25455](https://github.com/cypress-io/cypress/issues/25455).
- Improved memory consumption in `run` mode by removing reporter logs for successful tests. Fixes [#25230](https://github.com/cypress-io/cypress/issues/25230).

**Performance:**
**Bugfixes:**

- Improved memory consumption in `run` mode by removing reporter logs for successful tests.
Fixes [#25230](https://github.com/cypress-io/cypress/issues/25230).
- Fixed an issue where alternative Microsoft Edge Beta, Canary, and Dev binary versions were not being discovered by Cypress. Fixes [#25455](https://github.com/cypress-io/cypress/issues/25455).

**Dependency Updates:**
<!-- **Dependency Updates:** // this was committed with 'fix' instead of 'dependency' -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since dependabot generated those commits, do we need to change the messaging moving forward? Or does this change just get lumped under buxfixes?

Suggested change
<!-- **Dependency Updates:** // this was committed with 'fix' instead of 'dependency' -->
**Dependency Updates:**

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependabot PR title needs to be updated to use dependency: xyz. I assume we configured it initially so I just need to track it down.


- Upgraded [`underscore.string`](https://github.com/esamattis/underscore.string/blob/HEAD/CHANGELOG.markdown) from `3.3.5` to `3.3.6` to reference rebuilt assets after security patch to fix regular expression DDOS exploit.
- Upgraded [`underscore.string`](https://github.com/esamattis/underscore.string/blob/HEAD/CHANGELOG.markdown) from `3.3.5` to `3.3.6` to reference rebuilt assets after security patch to fix regular expression DDOS exploit. Fixed in [#25574](https://github.com/cypress-io/cypress/pull/25574).

## 12.4.1

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "cypress",
"version": "12.4.1",
"version": "12.5.0",
"description": "Cypress is a next generation front end testing tool built for the modern web",
"private": true,
"scripts": {
Expand Down
4 changes: 2 additions & 2 deletions scripts/semantic-commits/parse-changelog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ async function parseChangelog (pendingRelease = true) {
nextKnownLineBreak = index + 1
if (pendingRelease && !/_Released \d+\/\d+\/\d+ \(PENDING\)_/.test(line)) {
throw new Error(`Expected line number ${index + 1} to include "_Released xx/xx/xxxx (PENDING)_"`)
} else if (!pendingRelease && !/_Released \d+\/\d+\/\d+__/.test(line)) {
} else if (!pendingRelease && !/_Released \d+\/\d+\/\d+_/.test(line)) {
throw new Error(`Expected line number ${index + 1} to include "_Released xx/xx/xxxx_"`)
}

Expand All @@ -51,7 +51,7 @@ async function parseChangelog (pendingRelease = true) {
throw new Error(`Expected line number ${index + 1} to be a line break`)
}
} else {
const result = /\*\*.+?:\*\*/.exec(line)
const result = /^\*\*.+?:\*\*/.exec(line)

if (currentSection === '' && !result) {
throw new Error(`Expected line number ${index + 1} to be a valid section header. Received ${line}. Expected one of ...\n - ${userFacingSections.join('\n - ')}`)
Expand Down
6 changes: 3 additions & 3 deletions scripts/semantic-commits/validate-binary-changelog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,12 @@ const checkedInBinaryVersion = require('../../package.json').version

const changelog = async () => {
const latestReleaseInfo = await getCurrentReleaseData()
let hasVersionBump = checkedInBinaryVersion !== latestReleaseInfo.version

if (process.env.CIRCLECI) {
console.log({ checkedInBinaryVersion })

const hasVersionBump = checkedInBinaryVersion !== latestReleaseInfo.version

if (process.env.CIRCLE_BRANCH !== 'develop' && process.env.CIRCLE_BRANCH !== 'emily/changelog2' && !/^release\/\d+\.\d+\.\d+$/.test(process.env.CIRCLE_BRANCH) && !hasVersionBump) {
if (process.env.CIRCLE_BRANCH !== 'develop' && process.env.CIRCLE_BRANCH !== 'release-12.5.0' && !/^release\/\d+\.\d+\.\d+$/.test(process.env.CIRCLE_BRANCH) && !hasVersionBump) {
console.log('Only verify the entire changelog for develop, a release branch or any branch that bumped to the Cypress version in the package.json.')

return
Expand All @@ -30,6 +29,7 @@ const changelog = async () => {
return validateChangelog({
nextVersion,
changedFiles,
pendingRelease: !hasVersionBump,
commits,
})
}
Expand Down
4 changes: 2 additions & 2 deletions scripts/semantic-commits/validate-changelog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ const _handleErrors = (errors) => {
* Determines if the Cypress changelog has the correct next version and changelog entires given the provided
* list of commits.
*/
async function validateChangelog ({ changedFiles, nextVersion, commits }) {
async function validateChangelog ({ changedFiles, nextVersion, pendingRelease, commits }) {
const hasUserFacingCommits = commits.some(({ semanticType }) => hasUserFacingChange(semanticType))

if (!hasUserFacingCommits) {
Expand Down Expand Up @@ -138,7 +138,7 @@ async function validateChangelog ({ changedFiles, nextVersion, commits }) {
}
}

const changelog = await parseChangelog()
const changelog = await parseChangelog(pendingRelease)

if (nextVersion && !changelog.version === `## ${nextVersion}`) {
errors.push(`The changelog version does not contain the next Cypress version of ${nextVersion}. If the changelog version is correct, please correct the pull request title to correctly reflect the change being made.`)
Expand Down