chore: Fix flaky test #25726
Merged
chore: Fix flaky test #25726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlueWinds
requested review from
warrensplayer
and removed request for
warrensplayer
marktnoonan
approved these changes
Feb 6, 2023
My eyes just completely skipped over that comment every time I read the test, hah. Removed in eccf3a0. |
42 flaky tests on run #43836 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||
| Test | ||
|---|---|---|
| scaffolding component testing > vuecli4vue2 > scaffolds component testing for Vue CLI 4 w/ Vue 2 project |
Screenshot
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | ||
|---|---|---|
| network stubbing > intercepting request > can delay and throttle a StaticResponse | ||
e2e/origin/patches.cy.ts • 1 flaky test • 5x-driver-firefox
e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | ||
|---|---|---|
| cy.origin assertions > #consoleProps > .should() and .and() | ||
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox
| Test | ||
|---|---|---|
| ... > correctly returns currentRetry | ||
| ... > correctly returns currentRetry | ||
| ... > correctly returns currentRetry | ||
The first 5 flaky specs are shown, see all 21 specs in Cypress Cloud.
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
mike-plummer
approved these changes
Feb 6, 2023
tgriesser
added a commit
that referenced
this pull request
Feb 8, 2023
* develop: (28 commits) chore: update changelog validation example (#25742) fix: Improve error handling around calls to `this.next` in middleware (#25702) chore: debug page tooltip distance and artifact border (#25727) fix: update newProject ref when switching between organizations in SelectCloudProjectModal (#25730) misc: Add max widths to debug page message states (#25725) chore: export types (#25714) chore: release @cypress/webpack-preprocessor-v5.16.3 chore: release @cypress/vue-v5.0.4 chore: release @cypress/grep-v3.1.4 chore: Fix flaky test (#25726) dependency(deps): update dependency debug to ^4.3.4 🌟 (#25699) feat: openInIDE for failed debug spec (#25691) test: fix flaky CT test by relying on query (#25706) test: fix flaky migration test (#25672) misc: style change for responsiveness (#25687) misc: set min widths for icons (#25684) chore(deps): update dependency markdown-it to v11.0.1 🌟 (#25698) chore: Fix flaky origin .wait() test (#25693) chore: unskip tests (#25676) chore: release @cypress/webpack-preprocessor-v5.16.2 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This PR fixes a single flaky test.
Basically,
cypress-real-eventsdoesn't reset the browser's cursor position between tests or retries, resulting in, in some circumstances, tests that flake depending on what exactly is run before or after them and where it positioned the virtual mouse. Also, this test would never pass while retrying.This is why we don't use CDP for mouse events in Cypress core, despite the other advantages. Also, these tests don't work in Firefox at all.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?