fix: spawn child process with process.env in macOS arm64

[willmsC]

Add process.env to a child process identifying a custom browser on Apple Silicon.

Additional details

In our organization we use a custom Chrome browser which requires a number of basic environment variables, e.g. HOME, to load necessary configs.
When we try to run Cypress with this browser on Apple Silicon, it is not recognized. See log below:

> npx cypress run --browser="/Users/cwillms/Projects/custom_chrome/bin/macos/custom_chrome"
We could not identify a known browser at the path you provided: /Users/cwillms/Projects/custom_chrome/bin/macos/custom_chrome

Read more about how to troubleshoot launching browsers: https://on.cypress.io/troubleshooting-launching-browsers

The output from the command we ran was:

Unable to find browser with path /Users/cwillms/Projects/custom_chrome/bin/macos/custom_chrome
We could not identify a known browser at the path you provided: /Users/cwillms/Projects/custom_chrome/bin/macos/custom_chrome

Read more about how to troubleshoot launching browsers: https://on.cypress.io/troubleshooting-launching-browsers

The output from the command we ran was:

Unable to find browser with path /Users/cwillms/Projects/custom_chrome/bin/macos/custom_chrome

However, the browser is returning a correct version information when called:

> /Users/cwillms/Projects/custom_chrome/bin/macos/custom_chrome --version
Google Chrome 106.0.0

A detailed investigation showed that in the childprocess started in utils.ts (lines 19 to 29) only the ARCHPREFERENCE variable set in line 25 is available, but not the ones we need. For this reason, our custom browser could not be called in the childprocess and therefore could not return its versions information. I suggest to include also the process.env in this childprocess. This solved the problem for us.

When calling the childprocess for non Apple Silicon in line 33 this is already done implicitly, because no dedicated variables are set here.

PR Tasks

• Have tests been added/updated?
• Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
• [n/a] Has a PR for user-facing changes been opened in cypress-documentation?
• [n/a] Have API changes been updated in the type definitions?

[CLAassistant]

All committers have signed the CLA.

[cypress]

8 flaky tests on run #44004 ↗︎

0

5100

74

0

8

Details:

Merge branch 'develop' into develop
Project: cypress	Commit: 79d6a3bcad
Status: Passed	Duration: 14:11 💡
Started: Feb 13, 2023 3:43 PM	Ended: Feb 13, 2023 3:57 PM

  e2e/origin/cookie_behavior.cy.ts • 4 flaky tests • 5x-driver-electron

View Output Video

Test
... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)

  e2e/origin/commands/navigation.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test
cy.origin navigation > #consoleProps > .go()

  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test
... > correctly returns currentRetry
... > correctly returns currentRetry
... > correctly returns currentRetry

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[mschile]

Hi @willmsC 👋, thanks for this contribution! I added a few tests to verify the environment variables are correctly passed.

[flotwig]

@willmsC Thank you for the fix. This only start happening for you in 12.3.0, correct? #25014 seems like it would cause exactly this.

[willmsC]

@flotwig Yes, exactly. The changes in #25014 do indeed look like they are causing the issue.