fix: handle async before:spec event handler #26055
Conversation
30 flaky tests on run #44687 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > runs generated spec |
Output
Screenshots
Video
|
|
specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs |
Output
Screenshots
Video
|
|
cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution |
Output
Screenshots
Video
|
|
global-mode.cy.ts • 1 flaky test • launchpad-e2e
| Test | Artifacts | |
|---|---|---|
| ... > can be opened |
Output
Screenshots
Video
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| network stubbing > intercepting request > can delay and throttle a StaticResponse |
Output
Video
|
|
The first 5 flaky specs are shown, see all 17 specs in Cypress Cloud.
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
| project: 'plugin-after-spec-deletes-video', | ||
| spec: '*', | ||
| project: 'plugin-run-events', | ||
| // project: 'plugin-after-spec-deletes-video', |
| onMounted(() => { | ||
| // watch active spec, and re-run if it changes! | ||
| startSpecWatcher() |
There was a problem hiding this comment.
I wonder why we needed to wait until the element was rendered to call this?
There was a problem hiding this comment.
this is left over from attempts in trying to correct this behavior in open mode. changing back for now. but my original thought was there wasn't any. need to watch if a spec was changes from a user in the app if the content wasn't mounted & rendered yet.
| @@ -361,19 +360,31 @@ export class EventManager { | |||
| } | |||
|
|
|||
| setup (config) { | |||
| Cypress = this.Cypress = this.$CypressDriver.create(config) | |||
| this.ws.emit('watch:test:file', config.spec) | |||
There was a problem hiding this comment.
Do we want to watch the test file during run mode? This sounds like an open mode specific thing.
There was a problem hiding this comment.
Eg should this be under the check on line 365-368?
There was a problem hiding this comment.
It likely should but that is outside of the scope of this change and would require additionally testing. Going to leave as it for the PR.
| this.ws.emit('watch:test:file', config.spec) | ||
| resolve(null) | ||
| }) | ||
| }).then(() => { |
There was a problem hiding this comment.
You can (probably) just use async/await here (if you want, that is - I don't think this part is impacted by the whole "async doesn't work properly" since this is outside of the driver, but either way is fine by me.
There was a problem hiding this comment.
The async won't work properly concept is tied to writing Cypress tests, not the code so await should work fine.
|
I will assign @cypress-io/component-testing, since we are working in this area the most nowdays. |
…s-io/cypress into emily/before-spec-promise
Correctly await async
before:specevent handlers per the documentation specifications.PR Tasks
cypress-documentation?type definitions?