-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update Chrome renderer crash to be more terse and up to date #26597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennifer-shehane
changed the title
Update Chrome renderer crash to be more terse and up to date
fix: Update Chrome renderer crash to be more terse and up to date
Apr 26, 2023
mschile
reviewed
Apr 26, 2023
25 flaky tests on run #45938 ↗︎
Details:
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron
specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e
The first 5 flaky specs are shown, see all 14 specs in Cypress Cloud. This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
mschile
approved these changes
May 1, 2023
ryanthemanuel
approved these changes
May 1, 2023
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
In Cypress, when the Chromium renderer crashes, we display a very long error message. Some of the error is not actionable, some of the recommendations are outdated, some of it is repetitive. Overall, the content of the message may be ignored or some of the solutions inapplicable by users.
We wanted to improve the error message to be terse and actionable, leading them to the docs for more detail cypress-io/cypress-documentation#5223.
Steps to test
Snapshots should test this - they need to be updated.
How has the user experience changed?
Before
After
What changed
PR Tasks
cypress-documentation
? Remove line item about Docker workaround and the open issue cypress-documentation#5223