Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename upload results to upload screenshots & videos #26811

Merged
merged 2 commits into from
May 22, 2023

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented May 19, 2023

Additional details

Changes the nomenclature when printing a run when uploading artifacts, i.e. 'Uploading Results' to 'Uploading Screenshots & Videos' in an effort to be more explicit about the step occurring and to avoid confusing the user

Steps to test

How has the user experience changed?

PR Tasks

@AtofStryker AtofStryker force-pushed the chore/change_uploading_results branch from 2d2ff62 to 7f35fd4 Compare May 19, 2023 18:00
@AtofStryker AtofStryker force-pushed the chore/change_uploading_results branch from 7f35fd4 to b5f3f67 Compare May 22, 2023 13:40
@AtofStryker AtofStryker marked this pull request as ready for review May 22, 2023 13:46
@cypress
Copy link

cypress bot commented May 22, 2023

7 flaky tests on run #46633 ↗︎

0 5871 103 0 Flakiness 7

Details:

run ci
Project: cypress Commit: b5f3f67f45
Status: Passed Duration: 13:40 💡
Started: May 22, 2023 2:24 PM Ended: May 22, 2023 2:38 PM
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output Video
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
Flakiness  create-from-component.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
... > runs generated spec Output Screenshots Video
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Output Screenshots Video
Flakiness  cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@AtofStryker AtofStryker merged commit f524670 into develop May 22, 2023
@AtofStryker AtofStryker deleted the chore/change_uploading_results branch May 22, 2023 16:38
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 23, 2023

Released in 12.13.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.13.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update 'Uploading Results' to 'Uploading Screenshots & Videos' in terminal output
3 participants