-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rename upload results to upload screenshots & videos #26811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
commented
May 19, 2023
AtofStryker
force-pushed
the
chore/change_uploading_results
branch
from
May 19, 2023 18:00
2d2ff62
to
7f35fd4
Compare
AtofStryker
force-pushed
the
chore/change_uploading_results
branch
from
May 22, 2023 13:40
7f35fd4
to
b5f3f67
Compare
7 flaky tests on run #46633 ↗︎
Details:
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron
create-from-component.cy.ts • 1 flaky test • app-e2e
specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e
cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
mjhenkes
approved these changes
May 22, 2023
mschile
approved these changes
May 22, 2023
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Changes the nomenclature when printing a run when uploading artifacts, i.e. 'Uploading Results' to 'Uploading Screenshots & Videos' in an effort to be more explicit about the step occurring and to avoid confusing the user
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?