Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct typo in CONTRIBUTING #27343

Merged
merged 9 commits into from
Nov 14, 2023

Conversation

akatsuki-slayer
Copy link
Contributor

@akatsuki-slayer akatsuki-slayer commented Jul 19, 2023

Correct typo in CONTRIBUTING.md: 'an API' vs 'a API'

  • Closes: n/a

Additional details

A typo in CONTRIBUTING.md is fixed. Makes for better readability of Cypress documentation.

Steps to test:

n/a

How has the user experience changed?

n/a

PR Tasks

typo: 'an API' vs 'a API'
@CLAassistant
Copy link

CLAassistant commented Jul 19, 2023

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

@cypress
Copy link

cypress bot commented Jul 19, 2023

31 flaky tests on run #49850 ↗︎

0 27949 1353 0 Flakiness 31

Details:

Merge branch 'develop' into patch-1
Project: cypress Commit: d928620464
Status: Passed Duration: 23:16 💡
Started: Aug 14, 2023 12:35 AM Ended: Aug 14, 2023 12:58 AM
Flakiness  global-mode.cy.ts • 1 flaky test • launchpad-e2e

View Output Video

Test Artifacts
... > can be opened Output Screenshots Video
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Output Screenshots Video
Flakiness  cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution Output Screenshots Video
Flakiness  specs_list_switcher.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App: Spec List Testing Type Switcher > e2e unconfigured > switches testing types Output Screenshots Video
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output

The first 5 flaky specs are shown, see all 19 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@MikeMcC399
Copy link
Contributor

@siles-mitcawich

  1. Although this is a very simple change, you still need to sign the CLA
  2. The Semantic Pull Request check is failing. Please read https://github.com/cypress-io/cypress/actions/runs/5602707804/jobs/10248319633?pr=27343 and https://github.com/cypress-io/cypress/blob/develop/CONTRIBUTING.md#pull-requests. docs: correct typo in CONTRIBUTING would be one possible text.

@akatsuki-slayer akatsuki-slayer changed the title Update CONTRIBUTING.md docs: correct typo in CONTRIBUTING Jul 20, 2023
@akatsuki-slayer akatsuki-slayer marked this pull request as draft July 20, 2023 13:52
@akatsuki-slayer
Copy link
Contributor Author

Hi @MikeMcC399,

Thanks for the feedback.

  1. I was told that I am supposed to sign a corporate CLA if there is one instead of the individual CLA. I raised an issue about this Corporate CLA? #27345 but let me know if there isn't one and I can just sign the individual one.
  2. Should I raise an issue for this PR or is that unnecessary?

@MikeMcC399
Copy link
Contributor

@siles-mitcawich

  1. I was told that I am supposed to sign a corporate CLA if there is one instead of the individual CLA. I raised an issue about this Corporate CLA? #27345 but let me know if there isn't one and I can just sign the individual one.

I'm just a community member sharing their experience with you, so I won't get involved in the legal issues.

  1. Should I raise an issue for this PR or is that unnecessary?

I don't think that is necessary. It's just a typo in a document which doesn't form part of the published package and is only visible on GitHub.

@akatsuki-slayer akatsuki-slayer marked this pull request as ready for review August 14, 2023 00:25
@jennifer-shehane jennifer-shehane merged commit e308603 into cypress-io:develop Nov 14, 2023
26 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants