Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This issue resolves a situation where needless font requests get initiated due to adding a new style tag that tries to affect scrolling globally. There are appears to be a bug in chrome where when font face fonts are retrieved via "memory cache" any changes to stylesheets causes them to be re-retrieved. This has performance impacts as it floods CDP with events and it causes unnecessary entries for Test Replay. To resolve this, we try and be more surgical with how we affect scrolling. This issue does not occur with inline styles, so instead of setting something globally, we navigate the hierarchy of the elements and set
scrollBehavior
toauto
if the element is scrollable and has ascrollBehavior
ofsmooth
.Steps to test
There were existing tests to validate the
scrollBehavior
behavior. This change should not break those.How has the user experience changed?
n/a
PR Tasks
cypress-documentation
?type definitions
?