Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove Cypress Conf promo from README #28076

Merged
merged 1 commit into from
Oct 17, 2023
Merged

chore: remove Cypress Conf promo from README #28076

merged 1 commit into from
Oct 17, 2023

Conversation

astone123
Copy link
Contributor

Now that Cypress Conf is over, we should remove the promo from our readme

@astone123 astone123 self-assigned this Oct 17, 2023
@astone123 astone123 marked this pull request as ready for review October 17, 2023 20:15
@cypress
Copy link

cypress bot commented Oct 17, 2023 •
edited
Loading

4 flaky tests on run #51696 ↗︎

0 5357 76 0 Flakiness 4

Details:

chore: revert "chore: add Cypress Conf to README.md (#27569)"
Project: cypress Commit: 806acc6eac
Status: Passed Duration: 14:55 💡
Started: Oct 17, 2023 9:08 PM Ended: Oct 17, 2023 9:23 PM
Flakiness  commands/querying/querying.cy.js • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
... > throws when alias property isnt a digit or `all` Test Replay Output
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Test Replay Output
... > correctly returns currentRetry Test Replay Output
... > correctly returns currentRetry Test Replay Output

Review all test suite changes for PR #28076 ↗︎

jordanpowell88
jordanpowell88 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@jordanpowell88 jordanpowell88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@astone123 astone123 merged commit a96b9b1 into develop Oct 17, 2023
@astone123 astone123 deleted the remove-conf-promo branch October 17, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-plummer mike-plummer mike-plummer approved these changes

@jordanpowell88 jordanpowell88 jordanpowell88 approved these changes

Assignees

@astone123 astone123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@astone123 @jordanpowell88 @mike-plummer