Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Open app urls externally instead of in Cypress-launched browser #28351

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

chrisbreiding
Copy link
Contributor

@chrisbreiding chrisbreiding commented Nov 16, 2023

Additional details

Updates the AUT URL and "Learn more" command error links to open externally.

Links within the Cypress-launched browser should launch externally, especially since we don't recommend users browser within the Cypress browser and we will be closing extra tabs between tests and moving focus to the Cypress tab before commands.

Steps to test

AUT URL

  • Run a test with a visit
  • Click the AUT URL in the runner
  • It should open in your default browser

Learn more links

  • Run a test with a command failure like cy.viewport('foo')
  • Click the "Learn more" link
  • It should open in your default browser

PR Tasks

cli/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Matt Schile <mschile@cypress.io>
Copy link

cypress bot commented Nov 16, 2023

15 flaky tests on run #52352 ↗︎

0 15228 1099 0 Flakiness 15

Details:

Merge branch 'crb/cy-puppeteer-open-links-externally' of github.com:cypress-io/c...
Project: cypress Commit: f24c23f6a4
Status: Passed Duration: 15:11 💡
Started: Nov 16, 2023 7:30 PM Ended: Nov 16, 2023 7:45 PM
Flakiness  commands/querying/querying.cy.js • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
... > intercept aliases > returns the xhr Test Replay
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output

Test Artifacts
... > correctly returns currentRetry Test Replay
... > correctly returns currentRetry Test Replay
... > correctly returns currentRetry Test Replay
Flakiness  commands/storage.cy.ts • 1 flaky test • 5x-driver-chrome:beta

View Output

Test Artifacts
src/cy/commands/storage > #getAllLocalStorage > gets local storage from all origins Test Replay
Flakiness  e2e/origin/commands/storage.cy.ts • 1 flaky test • 5x-driver-chrome:beta

View Output

Test Artifacts
cy.origin storage > .getAllLocalStorage Test Replay
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-chrome:beta

View Output

Test Artifacts
... > correctly returns currentRetry Test Replay
... > correctly returns currentRetry Test Replay
... > correctly returns currentRetry Test Replay

The first 5 flaky specs are shown, see all 8 specs in Cypress Cloud.

Review all test suite changes for PR #28351 ↗︎

@chrisbreiding chrisbreiding merged commit d6e2a0d into develop Nov 16, 2023
80 of 82 checks passed
@chrisbreiding chrisbreiding deleted the crb/cy-puppeteer-open-links-externally branch November 16, 2023 19:47
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 21, 2023

Released in 13.6.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Learn more" link in reporter opens tab in Cypress browser rather than an external browser
4 participants