-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Open app urls externally instead of in Cypress-launched browser #28351
Merged
chrisbreiding
merged 5 commits into
develop
from
crb/cy-puppeteer-open-links-externally
Nov 16, 2023
Merged
fix: Open app urls externally instead of in Cypress-launched browser #28351
chrisbreiding
merged 5 commits into
develop
from
crb/cy-puppeteer-open-links-externally
Nov 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanthemanuel
approved these changes
Nov 16, 2023
emilyrohrbough
approved these changes
Nov 16, 2023
mschile
reviewed
Nov 16, 2023
mschile
approved these changes
Nov 16, 2023
Co-authored-by: Matt Schile <mschile@cypress.io>
15 flaky tests on run #52352 ↗︎
Details:
commands/querying/querying.cy.js • 1 flaky test • 5x-driver-electron
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron
commands/storage.cy.ts • 1 flaky test • 5x-driver-chrome:beta
e2e/origin/commands/storage.cy.ts • 1 flaky test • 5x-driver-chrome:beta
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-chrome:beta
The first 5 flaky specs are shown, see all 8 specs in Cypress Cloud. Review all test suite changes for PR #28351 ↗︎ |
…pen-links-externally
…ypress-io/cypress into crb/cy-puppeteer-open-links-externally
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Updates the AUT URL and "Learn more" command error links to open externally.
Links within the Cypress-launched browser should launch externally, especially since we don't recommend users browser within the Cypress browser and we will be closing extra tabs between tests and moving focus to the Cypress tab before commands.
Steps to test
AUT URL
Learn more links
cy.viewport('foo')
PR Tasks
cypress-documentation
?type definitions
?