fix: don't inherit default message for request logging #28411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _Released 12/5/2023 (PENDING)_ | ||
|
|
||
| **Bugfixes:** | ||
| - Fixed an issue where request logging would default the `message` to the `args` of the currently running command even though those `args` would not apply to the request log and are not displayed. If the `args` are sufficiently large (e.g. when running the `cy.task` from the [code-coverage](https://github.com/cypress-io/code-coverage/) plugin) there could be performance/memory implications. Addressed in [#28411](https://github.com/cypress-io/cypress/pull/28411). |
There was a problem hiding this comment.
This is a little confusing. 😅
There was a problem hiding this comment.
I'm open to suggestions :)
emilyrohrbough
approved these changes
Nov 27, 2023
chrisbreiding
approved these changes
Nov 28, 2023
ryanthemanuel
approved these changes
Nov 28, 2023
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
During
fetch/xhrrequest logging, we don’t set the log.message here which means when we create the message, we take the args of the current command as the message which is incorrect for a request log since it’s not related in any way to the current command.The message of the current command can be very large at times (e.g. when the
cy.taskof thecode-coverageplugin is running) which may have performance and memory implications both in the app and when recording for Test Replay.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?