dependency: replace circularJSON with flatted #28683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…press-io/cypress into em/special-char-serialization
emilyrohrbough
commented
Jan 11, 2024
2 flaky tests on run #53416 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs |
Test Replay
Screenshots
|
|
debug.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| App - Debug Page > shows running and updating build |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #28683 ↗︎
mschile
reviewed
Jan 11, 2024
| @@ -22,6 +22,7 @@ _Released 1/16/2024 (PENDING)_ | |||
|
|
|||
| - Remove dependency on `@types/node` package. Addresses [#28473](https://github.com/cypress-io/cypress/issues/28473). | |||
| - Updated `@cypress/unique-selector` to include a performance optimization. It's possible this could improve performance of the selector playground. Addressed in [#28571](https://github.com/cypress-io/cypress/pull/28571). | |||
| - Replace [`CircularJSON`](https://www.npmjs.com/package/circular-json) with its successor [`flatted`](https://www.npmjs.com/package/flatted) version `3.2.9`. This resolves decoding issues observed in complex objects sent from the browser. Addressed in [#28683](https://github.com/cypress-io/cypress/pull/28683). | |||
There was a problem hiding this comment.
If the entry is under the Dependency Updates: section, should the PR title be dependency:.
mschile
approved these changes
Jan 11, 2024
emilyrohrbough
changed the title
chrisbreiding
approved these changes
Jan 11, 2024
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where some complex data was not completely decoded when sent from the browser to the server. This was noted that the snapshot elementsToHighlight selector with a
~special char was encoded to\x7ebut never decoded.With this fix, we should not see the correct element highlights in test replay when a command is pinned. See Test Replay to verify content is highlighted as expected. (note: scroll appears to be broken so scroll to the bottom).
PR Tasks
cypress-documentation?type definitions?