-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency cypress-example-kitchensink to v2.0.2 #29058
chore(deps): update dependency cypress-example-kitchensink to v2.0.2 #29058
Conversation
|
Seems we can't get the tests to pass due to recent tests added, we're looking into it: #29072 |
|
3 flaky tests on run #54408 ↗︎
Details:
cypress/e2e/commands/net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkit
|
The issue with the failing tests has been resolved, so going to work on merging this in. Hold off on pulling in develop unless there are conflicts. |
Seems there's another issue with a newly introduced test around the |
Do you still want to process this PR? cypress-example-kitchensink@2.0.2 is now superseded by I'll leave it to you if you want to close this PR or not. |
@MikeMcC399 I'll merge this and another PR can be updated. We're doing a release today so this will at least get in. |
That's fine! I'll follow up again in the next couple of days as the GitHub pages sourcing https://example.cypress.io/ also need to be updated. |
@MikeMcC399 Yah I think that's done as part of the release process, so let us know if you don't see the changes published when the App is published. We haven't republished it in a while. |
|
It seems like c161eb5 is attempting to take care of the update to https://example.cypress.io/ although the page is currently lacking formatting. |
@MikeMcC399 We're looking at this |
@MikeMcC399 The site is fixed by rolling back the commits, so the new changes are not out. We need to investigate our deploy process. There's something that broke since we last deployed and it was never noticed. We'll open a new issue on the cypress repo to track this. |
Thanks for picking this up! At least now the scaffolded examples are in a much cleaner condition regarding correct chaining. |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
Updates packages/example to use cypress-example-kitchensink@2.0.2.
Steps to test
There are no changes to tests in this release. There are only text changes to the repo's description marking it as an E2E testing example.
How has the user experience changed?
This version changes the text on https://example.cypress.io/ to the following:
PR Tasks
cypress-documentation
?type definitions
?Next steps
https://github.com/cypress-io/cypress/blob/develop/packages/example/README.md#updating-the-example-app instructs to run
I can do this directly from a fork, however that only results in the site being deployed to the
gh-pages
branch in my fork. So it makes more sense for somebody with write access to the main repo to do it.