Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency cypress-example-kitchensink to v2.0.2 #29058

Merged
merged 9 commits into from
Mar 12, 2024

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Mar 5, 2024

Additional details

Updates packages/example to use cypress-example-kitchensink@2.0.2.

Steps to test

There are no changes to tests in this release. There are only text changes to the repo's description marking it as an E2E testing example.

How has the user experience changed?

This version changes the text on https://example.cypress.io/ to the following:

image

PR Tasks

Next steps

https://github.com/cypress-io/cypress/blob/develop/packages/example/README.md#updating-the-example-app instructs to run

yarn workspace @packages/example deploy

I can do this directly from a fork, however that only results in the site being deployed to the gh-pages branch in my fork. So it makes more sense for somebody with write access to the main repo to do it.

@cypress-app-bot
Copy link
Collaborator

@jennifer-shehane
Copy link
Member

Seems we can't get the tests to pass due to recent tests added, we're looking into it: #29072

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

Seems we can't get the tests to pass due to recent tests added, we're looking into it: #29072

Copy link

cypress bot commented Mar 6, 2024

3 flaky tests on run #54408 ↗︎

0 4645 948 0 Flakiness 3

Details:

Merge branch 'develop' into update/kitchensink
Project: cypress Commit: 8d5e1df188
Status: Passed Duration: 15:36 💡
Started: Mar 6, 2024 6:23 PM Ended: Mar 6, 2024 6:39 PM
Flakiness  cypress/e2e/commands/net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkit

View Output

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse
    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/54408/overview/802dadc5-c009-43f1-bedb-c1f5872275cd?reviewViewBy=FLAKY&utm_source=github&utm_medium=flaky&utm_campaign=view%20test">
        ... > with `times` > only uses each handler N times
      </a>
    </td>
    <td>
      
    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/54408/overview/a89be080-19f2-4f30-8ce3-71fda44956fe?reviewViewBy=FLAKY&utm_source=github&utm_medium=flaky&utm_campaign=view%20test">
        ... > stops waiting when an xhr request is canceled
      </a>
    </td>
    <td>
      
    </td>
  </tr></table>

Review all test suite changes for PR #29058 ↗︎

@jennifer-shehane
Copy link
Member

The issue with the failing tests has been resolved, so going to work on merging this in. Hold off on pulling in develop unless there are conflicts.

@jennifer-shehane
Copy link
Member

Seems there's another issue with a newly introduced test around the system-tests-firefox with the new screenshot behavior. We're investigating.

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

Do you still want to process this PR?

cypress-example-kitchensink@2.0.2 is now superseded by
cypress-example-kitchensink@2.0.3 and that would need to be a new PR. This latest version has content changes to the scaffolded tests regarding chaining corrections, so that should probably be processed as a fix with an entry in the changelog.

I'll leave it to you if you want to close this PR or not.

@jennifer-shehane
Copy link
Member

@MikeMcC399 I'll merge this and another PR can be updated. We're doing a release today so this will at least get in.

@jennifer-shehane jennifer-shehane merged commit 6e81db7 into cypress-io:develop Mar 12, 2024
67 checks passed
@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

I'll merge this and another PR can be updated. We're doing a release today so this will at least get in.

That's fine! I'll follow up again in the next couple of days as the GitHub pages sourcing https://example.cypress.io/ also need to be updated.

@MikeMcC399 MikeMcC399 deleted the update/kitchensink branch March 12, 2024 15:04
@jennifer-shehane
Copy link
Member

@MikeMcC399 Yah I think that's done as part of the release process, so let us know if you don't see the changes published when the App is published. We haven't republished it in a while.

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

Yah I think that's done as part of the release process, so let us know if you don't see the changes published when the App is published. We haven't republished it in a while.

  • I have seen PR chore: release 13.7.0 #29123 picking up cypress-example-kitchensink@2.0.3 so that is going into the next Cypress release without any corresponding changelog entry. Using the new cypress-example-kitchensink@2.0.3 release means that the examples automatically get updated. I don't think that this automatically publishes anything to https://example.cypress.io/ though otherwise the intro text would have already changed. Let's wait until 13.7.0 is released and take it from there.

@MikeMcC399
Copy link
Contributor Author

It seems like c161eb5 is attempting to take care of the update to https://example.cypress.io/ although the page is currently lacking formatting.

@jennifer-shehane
Copy link
Member

@MikeMcC399 We're looking at this

@jennifer-shehane
Copy link
Member

@MikeMcC399 The site is fixed by rolling back the commits, so the new changes are not out. We need to investigate our deploy process. There's something that broke since we last deployed and it was never noticed. We'll open a new issue on the cypress repo to track this.

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

The site is fixed by rolling back the commits, so the new changes are not out. We need to investigate our deploy process. There's something that broke since we last deployed and it was never noticed. We'll open a new issue on the cypress repo to track this.

Thanks for picking this up!

At least now the scaffolded examples are in a much cleaner condition regarding correct chaining.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 13, 2024

Released in 13.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.7.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants