-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: support activated service worker that is not handling requests #29349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…com/cypress-io/cypress into mschile/service_worker_uncontrolled
AtofStryker
reviewed
Apr 18, 2024
packages/proxy/test/unit/http/util/service-worker-manager.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Bill Glesias <bglesias@gmail.com>
Co-authored-by: Ryan Manuel <ryanm@cypress.io>
Co-authored-by: Bill Glesias <bglesias@gmail.com>
ryanthemanuel
approved these changes
Apr 22, 2024
AtofStryker
approved these changes
Apr 22, 2024
ryanthemanuel
approved these changes
Apr 23, 2024
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Currently, when a service worker is activated, we assume that the service worker is handling requests. However, a service worker doesn't start handling requests for the current scope unless
clients.claim
is called or a page within the scope is reloaded. In order to determine when a service worker is handling events, we are doing the following:clientsClaimed
client event to inform theServiceWorkerManager
that the service worker is now handling requests.clients.claim
to send theclientsClaimed
along with theclientUrls
that were claimed.ServiceWorkerManager
to watch for document requests that come in that indicate the service worker is now handling requests.Addressed a few other issues:
hash
from the url when receiving the service worker fetch event since the browser doesn't sendhash
causing the urls not to match which would lead to a timeoutproxy
to have access to the current browser so we can skip service worker injection for non-Chromium browsersfetch
handler to be called.Steps to test
Load a page with a service worker but don't call
clients.claim
or reload the page. Verify additional requests sent by the page do not timeout.How has the user experience changed?
Correlation timeouts are now longer experienced for service workers that are activated but not handling requests.
PR Tasks
cypress-documentation
?type definitions
?