Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize reduce in wrapConsoleProps #29501

Merged
merged 6 commits into from
Jun 3, 2024

Conversation

Connormiha
Copy link
Contributor

Additional details

I did a little optimization of reduce to avoid creating new object each iteration. And set O(n) instead of O(n*n).

Steps to test

How has the user experience changed?

PR Tasks

@cypress-app-bot
Copy link
Collaborator

@jennifer-shehane jennifer-shehane changed the title fix: optimize reduce in wrapConsoleProps perf: optimize reduce in wrapConsoleProps May 10, 2024
@jennifer-shehane
Copy link
Member

@cacieprins cacieprins self-requested a review May 10, 2024 16:12
@Connormiha
Copy link
Contributor Author

@Connormiha Could you include a changelog entry? Instructions are here: https://github.com/cypress-io/cypress/blob/develop/guides/writing-the-cypress-changelog.md#writing-guidelines

@jennifer-shehane Hello, I have added the changes

@jennifer-shehane jennifer-shehane merged commit f2894c4 into cypress-io:develop Jun 3, 2024
67 checks passed
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 4, 2024

Released in 13.11.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.11.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants