Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alias UI #2960

Merged
merged 28 commits into from
Jan 18, 2019
Merged

Update alias UI #2960

merged 28 commits into from
Jan 18, 2019

Conversation

lilaconlee
Copy link
Contributor

@lilaconlee lilaconlee force-pushed the issue-477-ui-alias-count branch from e919fb6 to 145c6d6 Compare December 17, 2018 20:42
@chrisbreiding
Copy link
Contributor

Testing this out, I'm seeing one issue. When a route with a glob is aliased, the cardinal number doesn't show up next to the alias reference. Look at 5,6,7:

screen shot 2019-01-11 at 10 02 01 am

The test looks like this:

  cy.route('/non-glob').as('non-glob')
  cy.route('/glob/*').as('glob')

  cy.wait('@non-glob')
  cy.wait('@non-glob')
  cy.wait('@non-glob')
  cy.wait('@glob')
  cy.wait('@glob')
  cy.wait('@glob')

Since the requests belong to the same alias, I think it should be:

5 WAIT (@glob|1)
6 WAIT (@glob|2)
7 WAIT (@glob|3)

Copy link
Contributor

@chrisbreiding chrisbreiding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I'm not seeing it work for non-globbed aliases 🤔

screen shot 2019-01-15 at 2 10 15 pm

Another thing is that when there's a grouped event that isn't aliased (see GET 404 /unaliased), the number doesn't have a border radius on the left (Looks like |3) when it should be (3).

@lilaconlee
Copy link
Contributor Author

@chrisbreiding woah yeah thanks for checking that out, i'll see about fixing it.

@lilaconlee lilaconlee force-pushed the issue-477-ui-alias-count branch from 7fd9e1e to 8a06fd8 Compare January 16, 2019 18:55
@lilaconlee
Copy link
Contributor Author

@chrisbreiding This should be ready for review again, think the reporter tests could be a little more robust so let me know if you have any advice there.

@chrisbreiding chrisbreiding merged commit 16f52cc into v4.0 Jan 18, 2019
@chrisbreiding chrisbreiding deleted the issue-477-ui-alias-count branch January 18, 2019 15:36
lilaconlee added a commit that referenced this pull request Jan 22, 2019
chrisbreiding pushed a commit that referenced this pull request Apr 10, 2019
* Update alias UI (#2960)

- Fixes #477

* fix reporter fixture name
laurinenas pushed a commit to laurinenas/cypress that referenced this pull request Apr 28, 2019
* Update alias UI (cypress-io#2960)

- Fixes cypress-io#477

* fix reporter fixture name
@flotwig flotwig restored the issue-477-ui-alias-count branch June 24, 2019 16:21
@flotwig flotwig deleted the issue-477-ui-alias-count branch January 24, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants