-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update alias UI #2960
Update alias UI #2960
Conversation
lilaconlee
commented
Dec 17, 2018
- Fixes Indicate when XHR's match aliases multiple times, and correlate those to waits #477
e919fb6
to
145c6d6
Compare
Testing this out, I'm seeing one issue. When a route with a glob is aliased, the cardinal number doesn't show up next to the alias reference. Look at 5,6,7: The test looks like this: cy.route('/non-glob').as('non-glob')
cy.route('/glob/*').as('glob')
cy.wait('@non-glob')
cy.wait('@non-glob')
cy.wait('@non-glob')
cy.wait('@glob')
cy.wait('@glob')
cy.wait('@glob') Since the requests belong to the same alias, I think it should be:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chrisbreiding woah yeah thanks for checking that out, i'll see about fixing it. |
7fd9e1e
to
8a06fd8
Compare
@chrisbreiding This should be ready for review again, think the reporter tests could be a little more robust so let me know if you have any advice there. |
* Update alias UI (cypress-io#2960) - Fixes cypress-io#477 * fix reporter fixture name