fix: [protocol] throw error verifying sig #29603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not throwing is surfacing as an upload error when it's a download error.
emilyrohrbough
changed the title
|
The error message also needs corrected/verified |
9 flaky tests on run #55750 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| scaffolding component testing > react-vite-ts-unconfigured > scaffolds component testing for React and Vite |
Test Replay
Screenshots
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| network stubbing > waiting and aliasing > yields the expected interception when two requests are raced |
Test Replay
|
|
commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when route is never resolved |
Test Replay
|
|
commands/querying/querying.cy.js • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| ... > throws when alias property is `0` |
Test Replay
|
|
commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when route is never resolved |
Test Replay
|
|
The first 5 flaky specs are shown, see all 8 specs in Cypress Cloud.
Review all test suite changes for PR #29603 ↗︎
|
Thank you for tracking down the cause of this error! Can a system test or unit test be added to verify the fix? |
ryanthemanuel
approved these changes
Jun 7, 2024
mschile
approved these changes
Jun 11, 2024
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not throwing is surfacing as an upload error when it's a download error.
Because it's not initialized, we are unable to determine the archive location and the error is captured as:
Now, the user is shown the following error:
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?