Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency prismjs to v1.27.0 [security] #29979

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 6, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
prismjs 1.21.0 -> 1.27.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2021-23341

The package prismjs before 1.23.0 are vulnerable to Regular Expression Denial of Service (ReDoS) via the prism-asciidoc, prism-rest, prism-tap and prism-eiffel components.

CVE-2021-32723

Some languages before 1.24.0 are vulnerable to Regular Expression Denial of Service (ReDoS).

Impact

When Prism is used to highlight untrusted (user-given) text, an attacker can craft a string that will take a very very long time to highlight. Do not use the following languages to highlight untrusted text.

  • ASCIIDoc
  • ERB

Other languages are not affected and can be used to highlight untrusted text.

Patches

This problem has been fixed in Prism v1.24.

References

CVE-2021-3801

Prism is a syntax highlighting library. The prismjs package is vulnerable to ReDoS (regular expression denial of service). An attacker that is able to provide a crafted HTML comment as input may cause an application to consume an excessive amount of CPU.

CVE-2022-23647

Impact

Prism's Command line plugin can be used by attackers to achieve an XSS attack. The Command line plugin did not properly escape its output, leading to the input text being inserted into the DOM as HTML code.

Server-side usage of Prism is not impacted. Websites that do not use the Command Line plugin are also not impacted.

Patches

This bug has been fixed in v1.27.0.

Workarounds

Do not use the Command line plugin on untrusted inputs, or sanitized all code blocks (remove all HTML code text) from all code blocks that use the Command line plugin.

References


Release Notes

PrismJS/prism (prismjs)

v1.27.0

Compare Source

New components
Updated components
Updated plugins
Other

v1.26.0

Compare Source

New components
Updated components
Updated plugins
Updated themes
Other

v1.25.0

Compare Source

New components
Updated components
Updated plugins
Updated themes
  • Twilight
Other

v1.24.1

Compare Source

Updated components
Updated plugins

v1.24.0

Compare Source

New components
Updated components
Updated plugins

Configuration

📅 Schedule: Branch creation - "" in timezone America/New_York, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@cypress-app-bot
Copy link
Collaborator

See the guidelines for reviewing dependency updates for info on how to review dependency update PRs.

@jennifer-shehane jennifer-shehane self-assigned this Aug 6, 2024
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the changes look good. Just adding support for things that were missing mostly.

There are some visual changes that look like an improvement listed below:

Before

Screenshot 2024-08-06 at 11 33 26 AM

After (timeout is colored red)

Screenshot 2024-08-06 at 11 33 33 AM

Copy link
Contributor Author

renovate bot commented Aug 6, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link

cypress bot commented Aug 6, 2024

cypress    Run #56407

Run Properties:  status check passed Passed #56407  •  git commit ca3ca4c427: empty commit
Project cypress
Branch Review renovate/npm-prismjs-vulnerability
Run status status check passed Passed #56407
Run duration 23m 31s
Commit git commit ca3ca4c427: empty commit
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 8
Tests that did not run due to a developer annotating a test with .skip  Pending 1328
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 29312
View all changes introduced in this branch ↗︎
UI Coverage  43.26%
  Untested elements 223  
  Tested elements 170  
Accessibility  91.238385%
  Failed rules  5 critical   10 serious   2 moderate   2 minor
  Failed elements 941  

@jennifer-shehane jennifer-shehane merged commit b20e939 into develop Aug 6, 2024
82 of 84 checks passed
@jennifer-shehane jennifer-shehane deleted the renovate/npm-prismjs-vulnerability branch August 6, 2024 16:30
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 14, 2024

Released in 13.13.3.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.13.3, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants