Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove deprecated @types/execa #30095

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

MikeMcC399
Copy link
Contributor

Additional details

The deprecated @types/execa npm module is removed:

"@types/execa": "0.9.0",

npm modules @types/execa is deprecated with the note:

This is a stub types definition. execa provides its own type definitions, so you do not need this installed.

npm module execa includes type definitions.

Steps to test

git clean -xfd
yarn

How has the user experience changed?

No change.

PR Tasks

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

All tests are passing so can I hand over to you to update the branch and re-run CI?

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the types were added to execa in 2.0.0, where technically our server and data-context packages are still using execa 1.0.0. 😒 https://github.com/sindresorhus/execa/releases/tag/v2.0.0

I'm still ok with this change though and would prefer to update those execa packages over keeping a 5 year old deprecated package.

@jennifer-shehane
Copy link
Member

@MikeMcC399 Yes, we'll get these PRs merged in

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

It looks like the types were added to execa in 2.0.0, where technically our server and data-context packages are still using execa 1.0.0. 😒 https://github.com/sindresorhus/execa/releases/tag/v2.0.0

Yes, you're right! Sorry I missed that. Cypress is using different versions of execa in different places.

I'm still ok with this change though and would prefer to update those execa packages over keeping a 5 year old deprecated package.

Do you want to update those execa 1.0.0 versions before merging this PR?

@jennifer-shehane jennifer-shehane merged commit c715753 into cypress-io:develop Aug 23, 2024
70 checks passed
@MikeMcC399 MikeMcC399 deleted the remove/types-execa branch August 23, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants