-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): migrate to community @faker-js/faker #30098
chore(deps): migrate to community @faker-js/faker #30098
Conversation
|
This comment was marked as resolved.
This comment was marked as resolved.
57e40ff
to
5153340
Compare
7e1e07c
to
3c4bf63
Compare
3c4bf63
to
3ba76b4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
@MikeMcC399 Great! I'll kick off the tests. |
3ba76b4
to
1eaedae
Compare
Thanks for picking out the failures! I reverted the tree-shaking syntax for importing faker which it seems is only good for The following tests all pass when run locally: yarn workspace @packages/frontend-shared cypress:run:ct
yarn workspace @packages/frontend-shared cypress:run:ct --browser chrome
yarn workspace @packages/frontend-shared check-ts
yarn workspace @packages/app check-ts |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
faker
to supported version #30096Additional details
The deprecated npm module faker@5.5.3 is migrated to the identical (non-deprecated) community version @faker-js/faker@5.5.3. See note in https://v6.fakerjs.dev/migration-guide-v5/
For background information read also I heard something happened. What's the TLDR?.
Steps to test
How has the user experience changed?
No change.
PR Tasks
cypress-documentation
?type definitions
?