Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): migrate to community @faker-js/faker #30098

Merged

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Aug 23, 2024

Additional details

The deprecated npm module faker@5.5.3 is migrated to the identical (non-deprecated) community version @faker-js/faker@5.5.3. See note in https://v6.fakerjs.dev/migration-guide-v5/

In addition to releasing all future versions under the @faker-js/faker package namespace, we have also provided all historical versions of Faker.

For background information read also I heard something happened. What's the TLDR?.

Steps to test

git clean -xfd
yarn
yarn workspace @packages/frontend-shared cypress:run:ct
yarn workspace @packages/frontend-shared check-ts
yarn workspace @packages/app check-ts

How has the user experience changed?

No change.

PR Tasks

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399

This comment was marked as resolved.

@MikeMcC399 MikeMcC399 force-pushed the migrate/faker-community-version branch from 57e40ff to 5153340 Compare August 24, 2024 07:19
@MikeMcC399 MikeMcC399 marked this pull request as ready for review August 24, 2024 07:23
@MikeMcC399 MikeMcC399 force-pushed the migrate/faker-community-version branch from 7e1e07c to 3c4bf63 Compare August 24, 2024 07:25
@MikeMcC399 MikeMcC399 closed this Aug 24, 2024
@MikeMcC399 MikeMcC399 deleted the migrate/faker-community-version branch August 24, 2024 08:06
@MikeMcC399 MikeMcC399 restored the migrate/faker-community-version branch August 24, 2024 13:29
@MikeMcC399 MikeMcC399 reopened this Aug 24, 2024
@MikeMcC399 MikeMcC399 force-pushed the migrate/faker-community-version branch from 3c4bf63 to 3ba76b4 Compare August 24, 2024 15:55
@MikeMcC399

This comment was marked as outdated.

@jennifer-shehane
Copy link
Member

@MikeMcC399 Great! I'll kick off the tests.

@jennifer-shehane
Copy link
Member

@MikeMcC399 Some relevant failures here: https://app.circleci.com/pipelines/github/cypress-io/cypress/63678/workflows/0390e57b-20a3-4945-827b-8fc6d4c5bf44/jobs/2640546/tests

Screenshot 2024-08-26 at 11 16 33 AM

@MikeMcC399 MikeMcC399 force-pushed the migrate/faker-community-version branch from 3ba76b4 to 1eaedae Compare August 26, 2024 16:44
@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

Thanks for picking out the failures!

I reverted the tree-shaking syntax for importing faker which it seems is only good for @faker-js/faker@6 and not for the legacy @faker-js/faker@5.5.3 version.

The following tests all pass when run locally:

yarn workspace @packages/frontend-shared cypress:run:ct
yarn workspace @packages/frontend-shared cypress:run:ct --browser chrome
yarn workspace @packages/frontend-shared check-ts
yarn workspace @packages/app check-ts

@jennifer-shehane jennifer-shehane merged commit 0480480 into cypress-io:develop Aug 26, 2024
68 checks passed
@MikeMcC399 MikeMcC399 deleted the migrate/faker-community-version branch August 27, 2024 04:40
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 27, 2024

Released in 13.14.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.14.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate faker to supported version
4 participants