Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency: bump @cypress/request to ^3.0.4 #30194

Merged
merged 19 commits into from
Sep 10, 2024
Merged

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Sep 5, 2024

  • Closes

Additional details

This bumps some dependencies of our @cypress/request library. TBH I was trying to address some vulnerabilities that a user surfaced. (I need to investigate why these wouldn't be surfaced by our Snyk scans.) At the end of the day, this update didn't actually fix those vulnerabilities since those deps exist on other deps we have also.

This should be a good fix regardless as it updates dependencies below which all contained fixes:

  • updates dependency form-data to ~2.5.0
  • updates dependency qs to v6.13.0
  • updates dependency http-signature to ~1.4.0

Steps to test

Tests pass

How has the user experience changed?

It's possible this could have fixed some issue for users.

PR Tasks

@jennifer-shehane
Copy link
Member Author

I don't know why my commit history keeps being weird when I open new PRs....

@jennifer-shehane jennifer-shehane self-assigned this Sep 5, 2024
Copy link

cypress bot commented Sep 6, 2024

cypress    Run #56986

Run Properties:  status check passed Passed #56986  •  git commit 9b06ac5696: Merge branch 'develop' into bump-request-lib
Project cypress
Branch Review bump-request-lib
Run status status check passed Passed #56986
Run duration 09m 24s
Commit git commit 9b06ac5696: Merge branch 'develop' into bump-request-lib
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 482
View all changes introduced in this branch ↗︎

Warning

No Report: Something went wrong and we could not generate a report for the Application Quality products.

@MikeMcC399
Copy link
Contributor

@jennifer-shehane

I don't know why my commit history keeps being weird when I open new PRs....

It sounds like you need to reset your local copy of the develop branch so that it matches the commit history on GitHub. That should remove all the merge commits you apparently have in your local copy.

@jennifer-shehane
Copy link
Member Author

@MikeMcC399 I reset everything on my side and it seems to be playing nicer.

@MikeMcC399
Copy link
Contributor

@jennifer-shehane

Would you want to update to @cypress/request@^3.0.5 now?

@jennifer-shehane
Copy link
Member Author

@MikeMcC399 I'll merge this first just in case that introduces something that breaks when we run it.

@jennifer-shehane jennifer-shehane merged commit 0a15c8d into develop Sep 10, 2024
84 of 85 checks passed
@jennifer-shehane jennifer-shehane deleted the bump-request-lib branch September 10, 2024 16:29
@MikeMcC399
Copy link
Contributor

@jennifer-shehane

I'll merge this first just in case that introduces something that breaks when we run it.

Understood.

New installations of Cypress in the field are going to pull @cypress/request@3.0.5 anyway, since the dependency is semver @cypress/request@^3.0.4.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 25, 2024

Released in 13.15.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.15.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants