-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependency: bump @cypress/request to ^3.0.4 #30194
Conversation
I don't know why my commit history keeps being weird when I open new PRs.... |
cypress Run #56986
Run Properties:
|
Project |
cypress
|
Branch Review |
bump-request-lib
|
Run status |
Passed #56986
|
Run duration | 09m 24s |
Commit |
9b06ac5696: Merge branch 'develop' into bump-request-lib
|
Committer | Jennifer Shehane |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
1
|
Skipped |
0
|
Passing |
482
|
View all changes introduced in this branch ↗︎ |
Warning
No Report: Something went wrong and we could not generate a report for the Application Quality products.
It sounds like you need to reset your local copy of the |
@MikeMcC399 I reset everything on my side and it seems to be playing nicer. |
Would you want to update to @cypress/request@^3.0.5 now? |
@MikeMcC399 I'll merge this first just in case that introduces something that breaks when we run it. |
Understood. New installations of Cypress in the field are going to pull |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
This bumps some dependencies of our @cypress/request library. TBH I was trying to address some vulnerabilities that a user surfaced. (I need to investigate why these wouldn't be surfaced by our Snyk scans.) At the end of the day, this update didn't actually fix those vulnerabilities since those deps exist on other deps we have also.
This should be a good fix regardless as it updates dependencies below which all contained fixes:
Steps to test
Tests pass
How has the user experience changed?
It's possible this could have fixed some issue for users.
PR Tasks
cypress-documentation
?type definitions
?