Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: Remove support for Node.js 16, Node.js 21, and glibc < 2.28 #30307

Merged
merged 9 commits into from
Oct 1, 2024

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Sep 27, 2024

Additional details

We don't have any tests for 16 or 21 currently, so no need to remove those: https://github.com/cypress-io/cypress/blob/remove-node-16-21-support/system-tests/test-binary/node_versions_spec.ts#L27

Steps to test

Not much right now actually

How has the user experience changed?

Cypress may not work properly in Node.js 16 and 21 moving forward.

PR Tasks

BREAKING CHANGE: Remove Node.js 16 and Node.js 21 support
@jennifer-shehane jennifer-shehane changed the base branch from develop to release/14.0.0 September 27, 2024 13:47
@jennifer-shehane jennifer-shehane changed the title Remove support for Node.js 16 and Node.js 21 feat(breaking: Remove support for Node.js 16 and Node.js 21 Sep 27, 2024
@jennifer-shehane jennifer-shehane changed the title feat(breaking: Remove support for Node.js 16 and Node.js 21 feat(breaking): Remove support for Node.js 16 and Node.js 21 Sep 27, 2024
@jennifer-shehane jennifer-shehane self-assigned this Sep 27, 2024
@jennifer-shehane jennifer-shehane changed the title feat(breaking): Remove support for Node.js 16 and Node.js 21 breaking: Remove support for Node.js 16 and Node.js 21 Sep 27, 2024
Copy link

cypress bot commented Sep 27, 2024

cypress    Run #57392

Run Properties:  status check passed Passed #57392  •  git commit 902dd13d6d: Merge branch 'release/14.0.0' into remove-node-16-21-support
Project cypress
Branch Review remove-node-16-21-support
Run status status check passed Passed #57392
Run duration 25m 22s
Commit git commit 902dd13d6d: Merge branch 'release/14.0.0' into remove-node-16-21-support
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 5
Tests that did not run due to a developer annotating a test with .skip  Pending 1326
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 29395
View all changes introduced in this branch ↗︎
UI Coverage  44.77%
  Untested elements 201  
  Tested elements 167  
Accessibility  91.29%
  Failed rules  5 critical   10 serious   2 moderate   2 minor
  Failed elements 943  

@jennifer-shehane jennifer-shehane changed the title breaking: Remove support for Node.js 16 and Node.js 21 breaking: Remove support for Node.js 16, Node.js 21, and glibc < 2.28 Sep 27, 2024
@@ -5,6 +5,9 @@ _Released 12/3/2024 (PENDING)_

**Breaking Changes:**

- Removed support for Node.js 16 and Node.js 21. Addresses [#29930](https://github.com/cypress-io/cypress/issues/29930).
- Prebuilt binaries for Linux are no longer compatible with Linux distributions based on glibc <2.28, for example: Ubuntu 14-18, RHEL 7, CentOS 7, Amazon Linux 2. Addresses [#29601](https://github.com/cypress-io/cypress/issues/29601).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somewhere we want to note that debian 10 is the target build for better-sqlite3 so if we bump the docker image base to bookworm we need to be aware to then build better-sqlite3 against the supported glibc version, which is currently 2.28.

@jennifer-shehane jennifer-shehane merged commit dab5047 into release/14.0.0 Oct 1, 2024
81 of 82 checks passed
@jennifer-shehane jennifer-shehane deleted the remove-node-16-21-support branch October 1, 2024 15:30
@jennifer-shehane jennifer-shehane mentioned this pull request Oct 1, 2024
28 tasks
mschile added a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants