fix: ensure that requests to the same resource will be properly intercepted even if they are sent in rapid succession #30435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cepted even if they are sent in rapid succession - run ci
ryanthemanuel
commented
Oct 21, 2024
mschile
approved these changes
Oct 21, 2024
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
ryanm/chore/fix-racing-net-stubbing-flake
|
| Run status |
|
| Run duration | 12m 25s |
| Commit |
|
| Committer | Ryan Manuel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
4
|
Skipped
|
0
|
Passing
|
233
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
67.07%
|
|
|---|---|
|
Untested elements
|
25
|
|
Tested elements
|
55
|
Accessibility
96.15%
|
|
|---|---|
|
Failed rules
|
0 critical
4 serious
1 moderate
0 minor
|
|
Failed elements
|
206
|
AtofStryker
reviewed
Oct 22, 2024
| }, | ||
| }) | ||
|
|
||
| state.pendingEventHandlers[frame.eventId](frame.data) |
There was a problem hiding this comment.
do we need a done handler here or something similar in the case the fake for some reason is not called and the test passes when it shouldn't?
There was a problem hiding this comment.
You can't mix and match promises and done, but I figured a better way to ensure this is getting called: 339a450 (#30435)
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
When requests go through the proxy, they execute the following middleware functions that affect
matchingRoutesthat get attached to the request:reqobjectToday, the set of matching requests gets set and then we associate subscriptions here. We then proceed synchronously until we await the request body. In that time we could receive other requests that get their subscriptions defined. If the first request is supposed to surpass the maximum number of requests that a given interception can handle, it is supposed to not be available for the second one. However, since they've both had their associated subscriptions defined prior to being handled, this causes the first interception to apply to both requests.
This change removes the gap that can occur when multiple requests for the same resource occur in rapid succession by moving the subscription association to after the async awaiting of the request body. We then do a sanity check when adding the subscriptions to ensure the routes we are using are not disabled.
Steps to test
Added some unit tests for this as it is very difficult to reliably test in a more integrated fashion
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?