breaking: remove deprecated before:browser:launch signature code that allowed Arrays #30460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: cypress-bot[bot] <41898282+cypress-bot[bot]@users.noreply.github.com>
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
remove-deprecated-before-browser-launch-args
|
| Run status |
|
| Run duration | 23m 45s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
6
|
Pending
|
1326
|
Skipped
|
0
|
Passing
|
29395
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
46.11%
|
|
|---|---|
|
Untested elements
|
189
|
|
Tested elements
|
166
|
Accessibility
92.54%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
908
|
BREAKING: remove deprecated before:browser:launch signature code that allowed Arrays
…//github.com/cypress-io/cypress into remove-deprecated-before-browser-launch-args
mschile
approved these changes
Oct 25, 2024
ryanthemanuel
approved these changes
Oct 28, 2024
jennifer-shehane
deleted the
remove-deprecated-before-browser-launch-args
branch
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
We changed the signature of
before:browser:launchin Cypress 4.0.0. We've been warning that this is deprecated when someone sends an array to one of the args. This PR removes this handling and warnings around people using the signature this way.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?