breaking: remove support for vite 2 and 3 from @cypress/vite-dev-server
#30489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
force-pushed
the
breaking/remove_wds3_from_cypress_webpack_dev_server
branch
from
dca2184 to
c40d117
Compare
AtofStryker
force-pushed
the
breaking/remove_vite_3_and_under_support
branch
from
a2ee392 to
7e7a378
Compare
AtofStryker
changed the title
@cypress/vite-dev-server
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
breaking/remove_vite_3_and_under_support
|
| Run status |
|
| Run duration | 21m 07s |
| Commit |
|
| Committer | AtofStryker |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
5
|
Pending
|
1327
|
Skipped
|
0
|
Passing
|
29369
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
46.24%
|
|
|---|---|
|
Untested elements
|
188
|
|
Tested elements
|
166
|
Accessibility
92.55%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
899
|
AtofStryker
added
the
npm: @cypress/vite-dev-server
Base automatically changed from
breaking/remove_wds3_from_cypress_webpack_dev_server
to
release/14.0.0
October 30, 2024 22:37
…nger supported by @cypress/vite-dev-server
…ings issue within vue)
…emoved test for allowing passing scaffolding for installing prereleases as we don't support prereleases ahead of time
…(expected since we are on 3 major versions ahead of vite) and install @cypress/vite-dev-server in correct packages [run ci]
AtofStryker
force-pushed
the
breaking/remove_vite_3_and_under_support
branch
from
93bffde to
149f592
Compare
AtofStryker
commented
Oct 30, 2024
| cy.startAppServer('component') | ||
|
|
||
| cy.visitApp() | ||
| cy.specsPageIsVisible() | ||
| cy.contains('App.cy.jsx').click() | ||
| cy.waitForSpecToFinish() | ||
| cy.get('.passed > .num').should('contain', 1) | ||
| // no support file means there is no mount function registered, so all tests should fail | ||
| cy.get('.failed > .num').should('contain', 2) |
There was a problem hiding this comment.
honestly not sure why this ever passed initially, but I would argue this is the correct behavior since there is no mount function.
AtofStryker
commented
Oct 30, 2024
| @@ -112,6 +112,11 @@ describe('scaffolding component testing', { | |||
| cy.findByTestId('dependency-react-dom').within(() => { | |||
| cy.get('[aria-label="installed"]').should('exist') | |||
| }) | |||
|
|
|||
| // now clean up the state that we mutated | |||
| cy.withCtx(async (ctx) => { | |||
There was a problem hiding this comment.
not a problem in CI but when rerunning this spec locally it fails due to polluted state in the project under test's dependencies
AtofStryker
commented
Oct 30, 2024
| expect(actual.bundler).to.eq('vite') | ||
| }) | ||
|
|
||
| it(`React with Vite using pre-release version`, async () => { |
There was a problem hiding this comment.
we support installing a pre release if we support that major version, which is kind of weird because we don't know if we will be compatible with the next major version, so we shouldn't actually support this OOTB and instead let users skip the install step to try the test harness
This was
linked to
issues
Oct 31, 2024
jennifer-shehane
approved these changes
Nov 1, 2024
mschile
approved these changes
Nov 1, 2024
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Removes support for
viteversion 2 and 3 from@cypress/vite-dev-server. This doesn't have a tremendous effect on the@cypress/vite-dev-serverpackage as far as actually supporting versions 2 and 3. It likely will still work, Cypress just no longer guarantees it and we will not detect the dependency when scaffolding CT. Therefore, all vite 2/3 tests are removed, or tests that are using older versions of vite/older dependencies are now updated.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation? chore: update supported vite versions for cypress 14 cypress-documentation#5978type definitions?