-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking: remove support for create react app for component testing as it is no longer maintained #30558
Conversation
cypress Run #58281
Run Properties:
|
Project |
cypress
|
Branch Review |
breaking/remove_create_react_app
|
Run status |
Passed #58281
|
Run duration | 09m 59s |
Commit |
b4aeb278b2: breaking: remove support for create react app for component testing as it is no ...
|
Committer | AtofStryker |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
1
|
Skipped |
0
|
Passing |
667
|
View all changes introduced in this branch ↗︎ |
UI Coverage
38.03%
|
|
---|---|
Untested elements |
132
|
Tested elements |
81
|
Accessibility
92.06%
|
|
---|---|
Failed rules |
3 critical
7 serious
1 moderate
1 minor
|
Failed elements |
540
|
825bcc4
to
b2ddc9c
Compare
9fd62df
to
bee6912
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some notes, nothing I think that's blocking. A lot of code removed!
module.exports = { | ||
component: { | ||
devServer: { | ||
framework: 'create-react-app', | ||
bundler: 'webpack', | ||
}, | ||
}, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this not need a replacement with another framework?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it gets replaced by react
and webpack
which we already support. but this file in general looks to be left over from when sessionAndOrigin went Ga so its dead code
# Getting Started with Create React App | ||
|
||
This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why we'd leave this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its to test an ejected version of create react app, which is really just a react/webpack application. I'd like to keep it because its almost a system test around a working migration away from cra
…s it is no longer maintained [run ci]
bee6912
to
b4aeb27
Compare
Additional details
Create React App is de-facto abandoned and unsupported. Because of this, Cypress has chosen to remove CRA support for Component Testing in Cypress 14. This means that
create-react-app
users will need to use eitherwebpack
orvite
to bundler their component tests.webpack
support is supported withcreate-react-app
if a user choses to eject their app.eject
?If starting cypress without doing any migration, this error will throw in the cypress config
However, users can migrate via
npm run eject
withcreate-react-app
, which will generate a webpack config. If users change their config from:to
this does work
It does work with new projects as react is selected and webpack is detected. However, a user will need to
eject
the application and point to the webpack config as shown above. Otherwise, the config will throw an error which is expectedSteps to test
Testing against prepublished binary to verify migration steps work as expected
How has the user experience changed?
PR Tasks
cypress-documentation
? chore: remove CRA docs from cypress 14 and add migration guide cypress-documentation#5987type definitions
?