chore: fix github token issue on windows with v8 snapshot action #30668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
approved these changes
Nov 22, 2024
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
ryanthemanuel-patch-2
|
| Run status |
|
| Run duration | 24m 15s |
| Commit |
|
| Committer | Ryan Manuel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
1326
|
Skipped
|
0
|
Passing
|
29400
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
46.11%
|
|
|---|---|
|
Untested elements
|
189
|
|
Tested elements
|
166
|
Accessibility
92.54%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
907
|
cypress-app-bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
…th v8 snapshot action (#30668)
cypress-app-bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
… v8 snapshot action (#30668)
cypress-app-bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
…th v8 snapshot action (#30668)
cypress-app-bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
… v8 snapshot action (#30668)
cypress-app-bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
…th v8 snapshot action (#30668)
cypress-app-bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
… v8 snapshot action (#30668)
ryanthemanuel
pushed a commit
that referenced
this pull request
Nov 22, 2024
* chore: updating v8 snapshot cache * index on develop: 68363c2 chore: release @cypress/vite-dev-server-v5.2.1 * index on develop: fe0e59b chore: fix updating v8 snapshot cache when pr already exists (#30665) * index on develop: 12af627 chore: fix github token issue on windows with v8 snapshot action (#30668) --------- Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
ryanthemanuel
pushed a commit
that referenced
this pull request
Nov 22, 2024
* chore: updating v8 snapshot cache * index on develop: 68363c2 chore: release @cypress/vite-dev-server-v5.2.1 * index on develop: 0038ee5 docs: fix link to moved changelog docs source (#30660) * index on develop: 0038ee5 docs: fix link to moved changelog docs source (#30660) * index on develop: fe0e59b chore: fix updating v8 snapshot cache when pr already exists (#30665) * index on develop: 12af627 chore: fix github token issue on windows with v8 snapshot action (#30668) --------- Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
ryanthemanuel
pushed a commit
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
I forgot a couple of lines on my last PR for the v8 snapshot action that are required for windows. This adds those back
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?