chore: automatically infer cypress major version from package.json #30911
+32
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/splash_page_autosource
|
| Run status |
|
| Run duration | 14m 40s |
| Commit |
|
| Committer | AtofStryker |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
133
|
Skipped
|
0
|
Passing
|
5542
|
| View all changes introduced in this branch ↗︎ | |
AtofStryker
force-pushed
the
chore/splash_page_autosource
branch
from
0fefa9d to
e52436e
Compare
…rsion and error when no splash page exists for said major version
AtofStryker
force-pushed
the
chore/splash_page_autosource
branch
from
e52436e to
e1564e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Automatically detects the major version of the Cypress package in order to display the splash page. If no splash page is added for the new major version, a test inside
MajorVersionWelcome.cy.tsxwill error alerting the team to add a testSteps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?