chore: bump firefox version we test against to 141 #32078
Conversation
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
bump-firefox-141
|
| Run status |
|
| Run duration | 20m 03s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
15
|
Pending
|
1230
|
Skipped
|
0
|
Passing
|
32179
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
45.83%
|
|
|---|---|
|
Untested elements
|
190
|
|
Tested elements
|
165
|
Accessibility
97.95%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
107
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
AtofStryker
force-pushed
the
bump-firefox-141
branch
from
b013f30 to
e97be81
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| // Firefox bidi returns "unspecified" for sameSite; | ||
| // webkit & firefox < 135 return "no_restriction" for sameSite; | ||
| // other browsers do not return sameSite at all | ||
| const sameSite = ( |
There was a problem hiding this comment.
I think the comment is helpful, but do we need the conditional logic as we really test the version of firefox rolling forward?
There was a problem hiding this comment.
We still test against FF 134 in CI
There was a problem hiding this comment.
That's my fault I keep thinking Cypress 15 🥴
| return ( | ||
| browser.family === 'firefox' && ( | ||
| Number(browser.majorVersion) < 135 || | ||
| (Number(browser.majorVersion) < 141 && !!process.env.FORCE_FIREFOX_CDP) |
There was a problem hiding this comment.
I would say it might be worth mentioning FORCE_FIREFOX_CDP doesn't work in Firefox 141 plus in a console warning but I am not convinced this option is used enough to warrant the extra work
There was a problem hiding this comment.
It's implied by the new warning message
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| // Firefox bidi returns "unspecified" for sameSite; | ||
| // webkit & firefox < 135 return "no_restriction" for sameSite; | ||
| // other browsers do not return sameSite at all | ||
| const sameSite = ( |
There was a problem hiding this comment.
That's my fault I keep thinking Cypress 15 🥴
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
141 Released today
Slack thread for details on Firefox 140 change to cookies
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?