Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Represent browsers as objects internally #3225

Merged
merged 35 commits into from
Feb 13, 2019
Merged

Represent browsers as objects internally #3225

merged 35 commits into from
Feb 13, 2019

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Jan 25, 2019 •
edited
Loading

Fixes #3218
Fixes #3183

@flotwig flotwig mentioned this pull request Jan 25, 2019
Closed
@CLAassistant
Copy link

CLAassistant commented Jan 28, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@flotwig flotwig force-pushed the issue-3218-browser-obj-rep branch 2 times, most recently from 5a0a720 to 3710de1 Compare January 28, 2019 19:30
@flotwig flotwig changed the title [WIP] Represent browsers as objects internally Represent browsers as objects internally Jan 28, 2019
@flotwig flotwig mentioned this pull request Jan 28, 2019
Closed
14 tasks
brian-mann
brian-mann requested changes Jan 31, 2019
View reviewed changes
Copy link
Member

@brian-mann brian-mann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think i understand everything in here but would like to do a manual pairing session for review

@flotwig flotwig force-pushed the issue-3218-browser-obj-rep branch 2 times, most recently from aabe7d3 to 51968cf Compare February 4, 2019 15:14
@flotwig flotwig mentioned this pull request Feb 4, 2019
Closed
@flotwig flotwig requested review from brian-mann and removed request for brian-mann February 5, 2019 23:43
@flotwig flotwig force-pushed the issue-3218-browser-obj-rep branch from f684be2 to cf48a5a Compare February 7, 2019 16:32
@flotwig flotwig mentioned this pull request Feb 8, 2019
Merged
3 tasks
brian-mann
brian-mann requested changes Feb 11, 2019
View reviewed changes
@flotwig flotwig force-pushed the issue-3218-browser-obj-rep branch 3 times, most recently from d16b0ed to f96af69 Compare February 11, 2019 20:11
@flotwig flotwig force-pushed the issue-3218-browser-obj-rep branch from f96af69 to 89a1a96 Compare February 11, 2019 20:34
@flotwig flotwig requested review from brian-mann and removed request for bahmutov February 11, 2019 21:25
@flotwig flotwig force-pushed the issue-3218-browser-obj-rep branch from 11488bf to 3276ef4 Compare February 11, 2019 21:34
@brian-mann brian-mann merged commit fc93ee4 into develop Feb 13, 2019
@flotwig flotwig mentioned this pull request Feb 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-mann brian-mann brian-mann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flotwig @CLAassistant @brian-mann