Skip to content

chore: remove unused ubuntu anchors and update publish binary #32854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 3, 2025
Merged

chore: remove unused ubuntu anchors and update publish binary #32854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1db1627
chore: remove unused ubuntu anchors and test publish binary against u…
AtofStryker Oct 30, 2025
876ef3a
chore: empty commit to run CI
AtofStryker Oct 30, 2025
b2ee9d0
remove trixie postfix
AtofStryker Oct 30, 2025
0a01ef7
correctly discover arm64 job as the name has now changed
AtofStryker Oct 30, 2025
21cefe7
remove branch build
AtofStryker Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .circleci/src/pipeline/@pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,10 @@ chrome-stable-version: &chrome-stable-version "141.0.7390.107"
chrome-beta-version: &chrome-beta-version "142.0.7444.34"
firefox-stable-version: &firefox-stable-version "142.0"
base-internal-trixie: &base-internal-trixie cypress/base-internal:22.19.0-trixie
base-internal-yarn-berry: &base-internal-yarn-berry cypress/base-internal:22.19.0-yarn-berry-trixie
base-internal-yarn-berry: &base-internal-yarn-berry cypress/base-internal:22.19.0-yarn-berry
# Lowest Node.js version we support of the minimum major version supported
# See https://docs.cypress.io/app/get-started/install-cypress#Nodejs
base-internal-minimum-node: &base-internal-minimum-node cypress/base-internal:20.15.0
ubuntu-2004-current: &ubuntu-2004-current ubuntu-2004:2024.11.1
ubuntu-2004-older: &ubuntu-2004-older ubuntu-2004:2024.05.1

orbs:
browser-tools: circleci/browser-tools@2.3.1
Expand Down Expand Up @@ -118,7 +116,7 @@ commands:
name: Set environment variable to determine whether or not to persist artifacts
command: |
echo "Setting SHOULD_PERSIST_ARTIFACTS variable"
echo 'if ! [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "chore/fix_builds" ]]; then
echo 'if ! [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "chore/remove_unused_anchors" ]]; then
export SHOULD_PERSIST_ARTIFACTS=true
fi' >> "$BASH_ENV"
# You must run `setup_should_persist_artifacts` command and be using bash before running this command
Expand Down
2 changes: 1 addition & 1 deletion .circleci/src/pipeline/workflows/@main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ linux-x64:
- equal: [ develop, << pipeline.git.branch >> ]
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
- equal: [ 'ryanm/fix/issue-with-sourcemaps', << pipeline.git.branch >> ]
- equal: [ 'chore/remove_unused_anchors', << pipeline.git.branch >> ]
- matches:
pattern: /^release\/\d+\.\d+\.\d+$/
value: << pipeline.git.branch >>
Expand Down
4 changes: 4 additions & 0 deletions scripts/binary/get-published-artifacts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ const getArtifactJobName = (platformKey) => {
return 'linux-amd-publish-binary'
}

if (platformKey === 'linux-arm64') {
return 'linux-arm64-publish-binary'
}

return 'publish-binary'
}

Expand Down
Loading