Skip to content

Conversation

@jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Oct 31, 2025

Additional details

We recently added this keyboard shortcut, but it's not in the keyboard shortcut dialog. https://github.com/cypress-io/cypress-services/pull/12000

Steps to test

  • yarn cypress:open
  • Click on keyboard shortcuts in the bottom left of the test runner

How has the user experience changed?

Before

Screenshot 2025-10-31 at 11 20 50 AM

After (Mac)

Screenshot 2025-10-31 at 11 36 21 AM

After (Windows/Linux)

Screenshot 2025-10-31 at 11 36 30 AM

PR Tasks


Note

Adds the Studio save shortcut (⌘+s/Ctrl+s) to the Keyboard Shortcuts modal with platform-specific display, plus tests, i18n copy, and changelog entry.

  • App UI:
    • Keyboard Shortcuts modal (packages/app/src/navigation/KeyboardBindingsModal.vue):
      • Display Studio save shortcut with platform-specific keys (['⌘','+','s'] on darwin, ['Ctrl','+','s'] otherwise), defaulting to darwin if unavailable.
      • Render + as plain text with adjusted spacing between key badges.
  • Tests:
    • Add comprehensive spec (packages/app/src/navigation/KeyboardBindingsModal.cy.tsx) covering rendering, platform-specific shortcuts (macOS/Windows/Linux), visibility when hidden, and modal close behavior; includes Percy snapshots.
  • i18n:
    • Add sidebar.keyboardShortcuts.studioSave to packages/frontend-shared/src/locales/en-US.json.
  • Changelog:
    • Document the new shortcut display in cli/CHANGELOG.md under 15.6.1.

Written by Cursor Bugbot for commit 1fc36b6. This will update automatically on new commits. Configure here.

@jennifer-shehane jennifer-shehane self-assigned this Oct 31, 2025
@cypress
Copy link

cypress bot commented Oct 31, 2025

cypress    Run #67182

Run Properties:  status check failed Failed #67182  •  git commit 1fc36b67d6: Merge branch 'develop' into keyboard-dialog-save-studio
Project cypress
Branch Review keyboard-dialog-save-studio
Run status status check failed Failed #67182
Run duration 19m 48s
Commit git commit 1fc36b67d6: Merge branch 'develop' into keyboard-dialog-save-studio
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 15
Tests that did not run due to a developer annotating a test with .skip  Pending 1098
Tests that did not run due to a failure in a mocha hook  Skipped 4
Tests that passed  Passing 26529
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  45.48%
  Untested elements 188  
  Tested elements 161  
Accessibility  97.99%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 101  

Tests for review

Failed  cypress/e2e/commands/window.cy.js • 1 failed test • 5x-driver-firefox

View Output

Test Artifacts
... > only logs once
    </td>
  </tr></table>
Flakiness  commands/files.cy.js • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
... > throws when there is an error reading the file Test Replay
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary Test Replay
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Test Replay Screenshots
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-chrome:beta

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary Test Replay
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-chrome:beta

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Test Replay Screenshots

The first 5 flaky specs are shown, see all 15 specs in Cypress Cloud.

cli/CHANGELOG.md Outdated
- The hitbox for expanding a grouped command has been widened. Addresses [#32778](https://github.com/cypress-io/cypress/issues/32778). Addressed in [#32783](https://github.com/cypress-io/cypress/pull/32783).
- Have cursor on hover of the AUT URL to show as pointer. Addresses [#32777](https://github.com/cypress-io/cypress/issues/32777). Addressed in [#32782](https://github.com/cypress-io/cypress/pull/32782).
- WebKit now prefers a cookie's fully qualified `domain` when requesting a cookie value via [`cy.getCookie()`](https://docs.cypress.io/api/commands/getcookie). If none are found, the cookie's apex domain will be used as a fallback. Addresses [#29954](https://github.com/cypress-io/cypress/issues/29954), [#29973](https://github.com/cypress-io/cypress/issues/29973) and [#30392](https://github.com/cypress-io/cypress/issues/30392). Addressed in [#32852](https://github.com/cypress-io/cypress/pull/32852).
- The keyboard shortcuts modal now displays the keyboard shortcut for saving Studio changes - `` + `s` for Mac or `Ctrl` + `s` for Windows/Linux. Addressed [#32862](https://github.com/cypress-io/cypress/issues/32862). Addressed in [#32864](https://github.com/cypress-io/cypress/pull/32864).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Duplicate changelog entry across releases.

The changelog entry for keyboard shortcuts modal is duplicated in both version 15.6.1 (lines 7-8) and version 15.6.0 (line 34). Since version 15.6.0 was already released on 11/4/2025, this change cannot be part of that version. The entry should only appear in version 15.6.1, not in the already-released 15.6.0 section.

Fix in Cursor Fix in Web

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing changelog entry for tooltip style update

An unrelated CHANGELOG entry about the 'Next' tooltip style update (PR #32866) has been accidentally removed from the 15.6.0 release notes. This deletion is not mentioned in the PR description and appears unrelated to adding the keyboard shortcut modal documentation.

cli/CHANGELOG.md#L32-L33

cypress/cli/CHANGELOG.md

Lines 32 to 33 in 1fc36b6

- Have cursor on hover of the AUT URL to show as pointer. Addresses [#32777](https://github.com/cypress-io/cypress/issues/32777). Addressed in [#32782](https://github.com/cypress-io/cypress/pull/32782).
- WebKit now prefers a cookie's fully qualified `domain` when requesting a cookie value via [`cy.getCookie()`](https://docs.cypress.io/api/commands/getcookie). If none are found, the cookie's apex domain will be used as a fallback. Addresses [#29954](https://github.com/cypress-io/cypress/issues/29954), [#29973](https://github.com/cypress-io/cypress/issues/29973) and [#30392](https://github.com/cypress-io/cypress/issues/30392). Addressed in [#32852](https://github.com/cypress-io/cypress/pull/32852).

Fix in Cursor Fix in Web


@jennifer-shehane jennifer-shehane merged commit 2a10b4f into develop Nov 6, 2025
11 of 13 checks passed
@jennifer-shehane jennifer-shehane deleted the keyboard-dialog-save-studio branch November 6, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Studio: Add new keyboard shortcut to keyboard shortcuts dialog in App

3 participants