-
Notifications
You must be signed in to change notification settings - Fork 3.4k
misc: Add keyboard shortcut to keyboard shortcut modal for saving studio changes #32864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
keyboard-dialog-save-studio
|
| Run status |
|
| Run duration | 19m 48s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
1
|
|
|
15
|
|
|
1098
|
|
|
4
|
|
|
26529
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.48%
|
|
|---|---|
|
|
188
|
|
|
161
|
Accessibility
97.99%
|
|
|---|---|
|
|
4 critical
8 serious
2 moderate
2 minor
|
|
|
101
|
Tests for review
cypress/e2e/commands/window.cy.js • 1 failed test • 5x-driver-firefox
cli/CHANGELOG.md
Outdated
| - The hitbox for expanding a grouped command has been widened. Addresses [#32778](https://github.com/cypress-io/cypress/issues/32778). Addressed in [#32783](https://github.com/cypress-io/cypress/pull/32783). | ||
| - Have cursor on hover of the AUT URL to show as pointer. Addresses [#32777](https://github.com/cypress-io/cypress/issues/32777). Addressed in [#32782](https://github.com/cypress-io/cypress/pull/32782). | ||
| - WebKit now prefers a cookie's fully qualified `domain` when requesting a cookie value via [`cy.getCookie()`](https://docs.cypress.io/api/commands/getcookie). If none are found, the cookie's apex domain will be used as a fallback. Addresses [#29954](https://github.com/cypress-io/cypress/issues/29954), [#29973](https://github.com/cypress-io/cypress/issues/29973) and [#30392](https://github.com/cypress-io/cypress/issues/30392). Addressed in [#32852](https://github.com/cypress-io/cypress/pull/32852). | ||
| - The keyboard shortcuts modal now displays the keyboard shortcut for saving Studio changes - `⌘` + `s` for Mac or `Ctrl` + `s` for Windows/Linux. Addressed [#32862](https://github.com/cypress-io/cypress/issues/32862). Addressed in [#32864](https://github.com/cypress-io/cypress/pull/32864). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Duplicate changelog entry across releases.
The changelog entry for keyboard shortcuts modal is duplicated in both version 15.6.1 (lines 7-8) and version 15.6.0 (line 34). Since version 15.6.0 was already released on 11/4/2025, this change cannot be part of that version. The entry should only appear in version 15.6.1, not in the already-released 15.6.0 section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing changelog entry for tooltip style update
An unrelated CHANGELOG entry about the 'Next' tooltip style update (PR #32866) has been accidentally removed from the 15.6.0 release notes. This deletion is not mentioned in the PR description and appears unrelated to adding the keyboard shortcut modal documentation.
cli/CHANGELOG.md#L32-L33
Lines 32 to 33 in 1fc36b6
| - Have cursor on hover of the AUT URL to show as pointer. Addresses [#32777](https://github.com/cypress-io/cypress/issues/32777). Addressed in [#32782](https://github.com/cypress-io/cypress/pull/32782). | |
| - WebKit now prefers a cookie's fully qualified `domain` when requesting a cookie value via [`cy.getCookie()`](https://docs.cypress.io/api/commands/getcookie). If none are found, the cookie's apex domain will be used as a fallback. Addresses [#29954](https://github.com/cypress-io/cypress/issues/29954), [#29973](https://github.com/cypress-io/cypress/issues/29973) and [#30392](https://github.com/cypress-io/cypress/issues/30392). Addressed in [#32852](https://github.com/cypress-io/cypress/pull/32852). |
Additional details
We recently added this keyboard shortcut, but it's not in the keyboard shortcut dialog. https://github.com/cypress-io/cypress-services/pull/12000
Steps to test
yarn cypress:openHow has the user experience changed?
Before
After (Mac)
After (Windows/Linux)
PR Tasks
cypress-documentation?type definitions?Note
Adds the Studio save shortcut (⌘+s/Ctrl+s) to the Keyboard Shortcuts modal with platform-specific display, plus tests, i18n copy, and changelog entry.
packages/app/src/navigation/KeyboardBindingsModal.vue):['⌘','+','s']ondarwin,['Ctrl','+','s']otherwise), defaulting todarwinif unavailable.+as plain text with adjusted spacing between key badges.packages/app/src/navigation/KeyboardBindingsModal.cy.tsx) covering rendering, platform-specific shortcuts (macOS/Windows/Linux), visibility when hidden, and modal close behavior; includes Percy snapshots.sidebar.keyboardShortcuts.studioSavetopackages/frontend-shared/src/locales/en-US.json.cli/CHANGELOG.mdunder15.6.1.Written by Cursor Bugbot for commit 1fc36b6. This will update automatically on new commits. Configure here.