Skip to content

Conversation

@cacieprins
Copy link
Contributor

@cacieprins cacieprins commented Nov 19, 2025

  • Closes

Additional details

Rather than modifying our circle config files, we can now trigger artifact persistence via a manual Circle workflow invocation.

Steps to test

How has the user experience changed?

PR Tasks


Note

Add a force-persist-artifacts pipeline parameter and update artifact persistence logic to honor it and simplify branch checks.

  • CI/CircleCI:
    • Parameters: Add force-persist-artifacts (boolean, default false) to /.circleci/config.yml and /.circleci/src/pipeline/@pipeline.yml.
    • Artifact persistence: Update setup_should_persist_artifacts to set SHOULD_PERSIST_ARTIFACTS when force-persist-artifacts is true; otherwise persist on develop and release/* branches; remove legacy branch exception.

Written by Cursor Bugbot for commit 1f79368. This will update automatically on new commits. Configure here.

@cacieprins cacieprins marked this pull request as ready for review November 19, 2025 15:24
@cacieprins cacieprins self-assigned this Nov 19, 2025
Copy link
Contributor

@AtofStryker AtofStryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cacieprins the mksnapshot command failed when I ran the pipeline? Do we need to configure something else additionally https://app.circleci.com/pipelines/github/cypress-io/cypress-publish-binary/16576/workflows/f5de6c49-b48a-4c9d-9f20-b7b05637e929/jobs/32056

@cypress
Copy link

cypress bot commented Nov 20, 2025

cypress    Run #67552

Run Properties:  status check failed Failed #67552  •  git commit 1f793689d2: Update config.yml
Project cypress
Branch Review ci/parameterize-persist-artifacts
Run status status check failed Failed #67552
Run duration 19m 28s
Commit git commit 1f793689d2: Update config.yml
Committer Cacie Prins
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 12
Tests that did not run due to a developer annotating a test with .skip  Pending 1097
Tests that did not run due to a failure in a mocha hook  Skipped 4
Tests that passed  Passing 26693
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  45.48%
  Untested elements 188  
  Tested elements 161  
Accessibility  97.99%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 101  

Tests for review

Failed  src/components/Tooltip.cy.tsx • 1 failed test • frontend-shared-ct

View Output

Test Artifacts
An uncaught error was detected outside of a test Test Replay
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Test Replay Screenshots
Flakiness  e2e/origin/commands/waiting.cy.ts • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
... > throws when foo cannot resolve Test Replay
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary Test Replay
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
... > stops waiting when an xhr request is canceled
    </td>
  </tr></table>
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Test Replay Screenshots

The first 5 flaky specs are shown, see all 12 specs in Cypress Cloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants