-
Notifications
You must be signed in to change notification settings - Fork 3.4k
chore: parameterize persist artifacts #32972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
AtofStryker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cacieprins the mksnapshot command failed when I ran the pipeline? Do we need to configure something else additionally https://app.circleci.com/pipelines/github/cypress-io/cypress-publish-binary/16576/workflows/f5de6c49-b48a-4c9d-9f20-b7b05637e929/jobs/32056
cypress
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
ci/parameterize-persist-artifacts
|
| Run status |
|
| Run duration | 19m 28s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
1
|
|
|
12
|
|
|
1097
|
|
|
4
|
|
|
26693
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.48%
|
|
|---|---|
|
|
188
|
|
|
161
|
Accessibility
97.99%
|
|
|---|---|
|
|
4 critical
8 serious
2 moderate
2 minor
|
|
|
101
|
Tests for review
src/components/Tooltip.cy.tsx • 1 failed test • frontend-shared-ct
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Test Replay
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
e2e/origin/commands/waiting.cy.ts • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| ... > throws when foo cannot resolve |
Test Replay
|
|
e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary |
Test Replay
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |||||||
|---|---|---|---|---|---|---|---|---|
| ... > stops waiting when an xhr request is canceled |
| |||||||
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
The first 5 flaky specs are shown, see all 12 specs in Cypress Cloud.
Additional details
Rather than modifying our circle config files, we can now trigger artifact persistence via a manual Circle workflow invocation.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Add a
force-persist-artifactspipeline parameter and update artifact persistence logic to honor it and simplify branch checks.force-persist-artifacts(boolean, defaultfalse) to/.circleci/config.ymland/.circleci/src/pipeline/@pipeline.yml.setup_should_persist_artifactsto setSHOULD_PERSIST_ARTIFACTSwhenforce-persist-artifactsistrue; otherwise persist ondevelopandrelease/*branches; remove legacy branch exception.Written by Cursor Bugbot for commit 1f79368. This will update automatically on new commits. Configure here.